fix(contacts): Use correct default for shareapi_allow_share_dialog_user_enumeration

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

Author: kesselb

lib/Service/ContactsIntegration.php

@@ -52,7 +52,7 @@ public function getMatchingRecipient(string $userId, string $term): array {
 
 		// If 'Allow username autocompletion in share dialog' is disabled in the admin sharing settings, then we must not
 		// auto-complete system users
-		$shareeEnumeration = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'no') === 'yes';
+		$shareeEnumeration = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes';
 		$shareeEnumerationInGroupOnly = $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_to_group', 'no') === 'yes';
 		$shareeEnumerationFullMatch = $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match', 'yes') === 'yes';
 		$shareeEnumerationFullMatchUserId = $shareeEnumerationFullMatch && $this->config->getAppValue('core', 'shareapi_restrict_user_enumeration_full_match_userid', 'yes') === 'yes';
@@ -233,7 +233,7 @@ public function newContact(string $name, string $mailAddr, string $type = 'HOME'
 	 * @param string[] $fields
 	 */
 	private function doSearch(string $term, array $fields, bool $strictSearch) : array {
-		$allowSystemUsers = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'no') === 'yes';
+		$allowSystemUsers = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes';
 
 		$result = $this->contactsManager->search($term, $fields, [
 			'strict_search' => $strictSearch,

lib/Service/Group/ContactsGroupService.php

@@ -44,7 +44,7 @@ public function search(string $term): array {
 
 		// If 'Allow username autocompletion in share dialog' is disabled in the admin sharing settings, then we must not
 		// auto-complete system users
-		$allowSystemUsers = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'no') === 'yes';
+		$allowSystemUsers = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes';
 
 		$result = $this->contactsManager->search($term, ['CATEGORIES']);
 		$receivers = [];
@@ -73,7 +73,7 @@ public function getUsers(string $groupId): array {
 
 		// If 'Allow username autocompletion in share dialog' is disabled in the admin sharing settings, then we must not
 		// auto-complete system users
-		$allowSystemUsers = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'no') === 'yes';
+		$allowSystemUsers = $this->config->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes') === 'yes';
 
 		$result = $this->contactsManager->search($groupId, ['CATEGORIES']);
 		$receivers = [];

tests/Unit/Service/ContactsIntegrationTest.php

@@ -347,7 +347,7 @@ public function common($term, $searchResult, $allowSystemUsers, $allowSystemUser
 		$this->config->expects(self::atLeast(3))
 			->method('getAppValue')
 			->withConsecutive(
-				['core', 'shareapi_allow_share_dialog_user_enumeration', 'no'],
+				['core', 'shareapi_allow_share_dialog_user_enumeration', 'yes'],
 				['core', 'shareapi_restrict_user_enumeration_to_group', 'no'],
 				['core', 'shareapi_restrict_user_enumeration_full_match', 'yes'],
 				['core', 'shareapi_restrict_user_enumeration_full_match_userid', 'yes'],

tests/Unit/Service/Group/ContactsGroupServiceTest.php

@@ -72,7 +72,7 @@ public function testSearchGroups() {
 		];
 		$this->config->expects($this->once())
 			->method('getAppValue')
-			->with('core', 'shareapi_allow_share_dialog_user_enumeration', 'no')
+			->with('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes')
 			->willReturn('yes');
 		$this->contactsManager->expects($this->once())
 			->method('isEnabled')
@@ -135,7 +135,7 @@ public function testGetUsersForGroup() {
 		];
 		$this->config->expects($this->once())
 			->method('getAppValue')
-			->with('core', 'shareapi_allow_share_dialog_user_enumeration', 'no')
+			->with('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes')
 			->willReturn('yes');
 		$this->contactsManager->expects($this->once())
 			->method('isEnabled')