Skip to content

Commit 14a875e

Browse files
committed
fix: Dont hijack mailto links
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
1 parent f3eb3d4 commit 14a875e

File tree

2 files changed

+1
-14
lines changed

2 files changed

+1
-14
lines changed

lib/Service/Html.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ public function sanitizeHtmlMailBody(string $mailBody, array $messageParameters,
126126
$html = $config->getDefinition('HTML');
127127
$html->info_attr_transform_post['imagesrc'] = new TransformImageSrc($this->urlGenerator);
128128
$html->info_attr_transform_post['cssbackground'] = new TransformStyleURLs($this->urlGenerator);
129-
$html->info_attr_transform_post['htmllinks'] = new TransformHTMLLinks($this->urlGenerator);
129+
$html->info_attr_transform_post['htmllinks'] = new TransformHTMLLinks();
130130

131131
/** @var HTMLPurifier_URIDefinition $uri */
132132
$uri = $config->getDefinition('URI');

lib/Service/HtmlPurify/TransformHTMLLinks.php

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,19 +13,11 @@
1313
use HTMLPurifier_AttrTransform;
1414
use HTMLPurifier_Config;
1515
use HTMLPurifier_Context;
16-
use OCP\IURLGenerator;
1716

1817
/**
1918
* Adds target="_blank" to all outbound links.
2019
*/
2120
class TransformHTMLLinks extends HTMLPurifier_AttrTransform {
22-
/** @var IURLGenerator */
23-
private $urlGenerator;
24-
25-
public function __construct(IURLGenerator $urlGenerator) {
26-
$this->urlGenerator = $urlGenerator;
27-
}
28-
2921
/**
3022
* @param array $attr
3123
* @param HTMLPurifier_Config $config
@@ -41,11 +33,6 @@ public function transform($attr, $config, $context) {
4133
$attr['target'] = '_blank';
4234
$attr['rel'] = 'external noopener noreferrer';
4335

44-
// Open mailto: links in Mail
45-
if (stripos($attr['href'], 'mailto:') === 0) {
46-
$attr['href'] = $this->urlGenerator->linkToRoute('mail.page.mailto') . '?to=' . substr($attr['href'], 7);
47-
}
48-
4936
return $attr;
5037
}
5138
}

0 commit comments

Comments
 (0)