Move the edit button closer to the content

[max-nextcloud]

Is your feature request related to a problem? Please describe.
The edit / done buttons are quite far away from the content they refer to right now - in particular on the landing page.

We try to compensate that by making the button the primary - which maybe it does not need to be.

Describe the solution you'd like

• Move the edit button closer to the content. Either into the metadata bar with the last edited timestamp or even below floating above the content.
• Reuse the ✔️ button of the editor as the done button.

Screenshots

🏚️ Before	🏡 After

[max-nextcloud]

Looks like this would still fit both on mobile and on desktop if there are backlinks and attachments (at least with english locale and a somewhat short username):

[max-nextcloud]

Using the ✔️ save button of the text editor in place of the done button is a little more involved.
The editor will need to emit a signal when the file is saved by the user (ctrl-s or ✔️ button). This normally only works if there are local changes to be saved - not if they have already been autosaved. So we'd also need a way to tell the editor to always allow 'saving'.

So maybe this is not as good an idea as i thought.

[mejo-]

Reuse the ✔️ button of the editor as the done button.

That would mean that you cannot save manually without switching to read mode, right?

In theory I agree with you that moving the edit/done button closer to the content would be nice. But each time I think about possible alternatives, I quickly realize that they bring new problems 😬

There's also already #1099 which is somewhat related.

[max-nextcloud]

How about having a done button floating at the bottom right of the text. That seems like a common place to submit something (like the comment here on github).

Even the pattern of clicking on the top right corner to start editing something and then submitting on the bottom right seems common.

[marcoambrosini]

Nice idea to brig the button closer to the text.
I would not put the done button in a different place. Couldn't we just leave it where it is and flip the state like it is now?

[max-nextcloud]

@marcoambrosini The Edit button would fit in the infobar. However the infobar is replaced by the menu bar when editing - and there's no obvious space to fit the Done button. We'd have to shift the Collaborator list etc to the left to make room for it and eventually collapse more menu items into the more menu.

[marcoambrosini]

Thanks for explaining this. I see two considerations:

1. Toolbar space: In principle, keeping the edit button in the toolbar is fine if we collapse other elements in the more menu or things like like text styles into their own submenu to make room.

2. Consistency concern: The edit button would be in two different locations: top of the page on regular pages vs. info/toolbar in the home page. Initially I thought we could move it there for all pages, but since for other pages this should also lock the title (currently it doesn't, is it a bug?), moving it below the title would not make much sense

I'm not sure that the benefit of moving it closer to the text in the home page outweighs having the button in the same place regardless of page type. I'm not strongly leaning towards either direction though.

[max-nextcloud]

Regarding 2) The button is not related to the Title at all. The landing page title is the collective name and can only be changed in the settings of the collective. For all other pages the title can always be changed - independent of the edit / done state.
That's one of the reasons why i'd like to move it. Right now it looks like it's also the Done button for editing the title.