fix(import): cancel pending import when plan has no steps

When an unfinished plan computes no steps the wizard bails out early,
but it left the importer marked as busy. That stale busy state could
block later imports, so clear it on the way out.

Also cover the new-video case where the second video keeps the same
resolution, to make sure dimensions still emit when nothing changed.

Author: trin94

mpvqc/dialogs/dialog_loader.py

@@ -43,6 +43,7 @@ def releaseActiveDialog(self) -> None:
     def _request_import_wizard(self, unfinished_plan: UnfinishedPlan) -> None:
         if not compute_steps(unfinished_plan):
             logger.error("UnfinishedPlan has no steps; unfinished_plan=%r", unfinished_plan)
+            self._importer.cancel_pending()
             return
 
         self._active_dialog_vm = MpvqcImportWizardViewModel(self, unfinished_plan)

test/dialogs/test_dialog_loader.py

@@ -65,7 +65,7 @@ def test_releases_view_model_after_wizard(loader):
     _assert_view_model_collected(captured[0])
 
 
-def test_does_not_request_wizard_when_plan_has_no_steps(loader):
+def test_does_not_request_wizard_when_plan_has_no_steps(loader, importer_service_mock):
     requested: list[QObject] = []
     loader.importWizardDialogRequested.connect(lambda vm: requested.append(vm))
 
@@ -81,6 +81,7 @@ def test_does_not_request_wizard_when_plan_has_no_steps(loader):
 
     assert requested == []
     assert loader._active_dialog_vm is None
+    importer_service_mock.cancel_pending.assert_called_once_with()
 
 
 def test_release_cancels_pending_when_importer_busy(loader, importer_service_mock):

test/services/player/test_observe_property.py

@@ -3,6 +3,7 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
 from dataclasses import dataclass, fields
+from typing import NamedTuple
 
 import pytest
 
@@ -199,19 +200,33 @@ def test_video_dimensions_emitted_once_both_arrive(player_service, make_spy):
     assert spy.at(0, 1) == 1080
 
 
-def test_video_dimensions_emitted_again_after_new_video(player_service, make_spy):
+class NewVideoCase(NamedTuple):
+    name: str
+    width: int
+    height: int
+
+
+@pytest.mark.parametrize(
+    "case",
+    [
+        NewVideoCase("different resolution", 1280, 720),
+        NewVideoCase("same resolution", 1920, 1080),
+    ],
+    ids=lambda case: case.name,
+)
+def test_video_dimensions_emitted_again_after_new_video(player_service, make_spy, case):
     player_service._apply_property_update("path", "/movies/a.mkv")
     player_service._apply_property_update("width", 1920)
     player_service._apply_property_update("height", 1080)
 
     spy = make_spy(player_service.video_dimensions_changed)
     player_service._apply_property_update("path", "/movies/b.mkv")
-    player_service._apply_property_update("width", 1280)
-    player_service._apply_property_update("height", 720)
+    player_service._apply_property_update("width", case.width)
+    player_service._apply_property_update("height", case.height)
 
     assert spy.count() == 1
-    assert spy.at(0, 0) == 1280
-    assert spy.at(0, 1) == 720
+    assert spy.at(0, 0) == case.width
+    assert spy.at(0, 1) == case.height
 
 
 def test_property_updates_apply_after_event_loop_hop(qt_app, player_service):