Skip to content

Commit f77a29c

Browse files
authored
Fix pick+place tutorial: allow collision of object with coarse hand model (#741)
1 parent c6b769a commit f77a29c

File tree

3 files changed

+27
-16
lines changed

3 files changed

+27
-16
lines changed

.github/workflows/ci.yaml

Lines changed: 18 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ on:
88
pull_request:
99
push:
1010

11+
permissions:
12+
contents: read # to fetch code (actions/checkout)
13+
1114
jobs:
1215
ci:
1316
strategy:
@@ -25,38 +28,41 @@ jobs:
2528
name: ${{ matrix.env.IMAGE }}${{ matrix.env.CATKIN_LINT && ' + catkin_lint' || ''}}${{ matrix.env.CLANG_TIDY && ' + clang-tidy' || '' }}
2629
runs-on: ubuntu-latest
2730
steps:
28-
- uses: actions/checkout@v2
31+
- uses: actions/checkout@v3
2932
# The target directory cache doesn't include the source directory because
3033
# that comes from the checkout. See "prepare target_ws for cache" task below
31-
- name: cache target_ws
32-
uses: pat-s/always-upload-cache@v2.1.5
34+
- name: Cache target workspace
35+
uses: rhaschke/cache@main
3336
with:
3437
path: ${{ env.BASEDIR }}/target_ws
3538
key: ${{ env.CACHE_PREFIX }}-${{ github.run_id }}
3639
restore-keys: ${{ env.CACHE_PREFIX }}
3740
env:
41+
GHA_CACHE_SAVE: always
3842
CACHE_PREFIX: target_ws-${{ matrix.env.IMAGE }}-${{ hashFiles('**/CMakeLists.txt', '**/package.xml') }}
39-
- name: cache ccache
40-
uses: pat-s/always-upload-cache@v2.1.5
43+
- name: Cache ccache
44+
uses: rhaschke/cache@main
4145
with:
4246
path: ${{ env.CCACHE_DIR }}
4347
key: ${{ env.CACHE_PREFIX }}-${{ github.sha }}-${{ github.run_id }}
4448
restore-keys: |
4549
${{ env.CACHE_PREFIX }}-${{ github.sha }}
4650
${{ env.CACHE_PREFIX }}
4751
env:
52+
GHA_CACHE_SAVE: always
4853
CACHE_PREFIX: ccache-${{ matrix.env.IMAGE }}
4954

50-
- name: industrial_ci
55+
- name: Run industrial_ci
5156
uses: ros-industrial/industrial_ci@master
57+
env: ${{ matrix.env }}
5258

53-
- name: upload test artifacts (on failure)
54-
uses: actions/upload-artifact@v2
55-
if: failure()
59+
- name: Upload test artifacts (on failure)
60+
uses: actions/upload-artifact@v3
61+
if: failure() && (steps.ici.outputs.run_target_test || steps.ici.outputs.target_test_results)
5662
with:
57-
name: test-results
63+
name: test-results-${{ matrix.env.IMAGE }}
5864
path: ${{ env.BASEDIR }}/target_ws/**/test_results/**/*.xml
59-
- name: prepare target_ws for cache
65+
- name: Prepare target_ws for cache
6066
if: ${{ always() }}
6167
run: |
6268
du -sh ${{ env.BASEDIR }}/target_ws
@@ -69,7 +75,7 @@ jobs:
6975
runs-on: ubuntu-latest
7076
container: ros:melodic-ros-base
7177
steps:
72-
- uses: actions/checkout@v2
78+
- uses: actions/checkout@v3
7379
- name: "Install ruby"
7480
run: |
7581
apt-get update -q

.github/workflows/format.yaml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,18 @@ on:
88
pull_request:
99
push:
1010

11+
permissions:
12+
contents: read # to fetch code (actions/checkout)
13+
1114
jobs:
1215
pre-commit:
1316
name: pre-commit
14-
runs-on: ubuntu-latest
17+
runs-on: ubuntu-20.04
1518
steps:
16-
- uses: actions/checkout@v2
17-
- uses: actions/setup-python@v2
19+
- uses: actions/checkout@v3
1820
- name: Install clang-format-10
1921
run: sudo apt-get install clang-format-10
2022
- uses: rhaschke/install-catkin_lint-action@v1.0
2123
with:
2224
distro: melodic
23-
- uses: pre-commit/action@v2.0.0
25+
- uses: pre-commit/action@v3.0.0

doc/pick_place/src/pick_place_tutorial.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,9 @@ void pick(moveit::planning_interface::MoveGroupInterface& move_group)
8686
std::vector<moveit_msgs::Grasp> grasps;
8787
grasps.resize(1);
8888

89+
// Allow collisions of panda_hand_sc with object
90+
grasps[0].allowed_touch_objects.push_back("panda_hand_sc");
91+
8992
// Setting grasp pose
9093
// ++++++++++++++++++++++
9194
// This is the pose of panda_link8. |br|

0 commit comments

Comments
 (0)