Skip to content

Please tag the pre-commit commit #28

@bmoeskau

Description

@bmoeskau

First off, thanks a ton for adding pre-commit support! That's incredibly helpful.

I got tripped up trying to install it as a hook, because most pre-commit users are used to grabbing the latest tag by default and installing from that. However, using "v0.5" here yields the cryptic pre-commit error:

An error has occurred: InvalidManifestError:
=====> /Users/bmoeskau/.cache/pre-commit/repotdfzgo7g/.pre-commit-hooks.yaml does not exist
Check the log at /Users/bmoeskau/.cache/pre-commit/pre-commit.log

It took me a little while to figure out that pre-commit support was added in Dec 2018, after the last tag was applied in Nov 2018. The workaround is to use the commit hash instead, which works, but is a bit non-standard (and certainly confusing by default).

The simple fix would be to simply tag that commit, e.g. as v0.6. Until then, here's the currently-working pre-commit config required for anyone else who runs across this error:

  - repo: https://github.com/motet-a/jinjalint
    rev: 01e0a4d8
    hooks:
      - id: jinjalint

Thanks!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions