Skip to content

Commit 7eb98ad

Browse files
ochafikclaude
andauthored
fix: E2E test fixes and host resilience improvements (#206)
1. video-resource-server: Add missing server-utils.ts and fix import path - Was importing from non-existent ../shared/server-utils.js - Now correctly imports from ./src/server-utils.js 2. basic-host: Be resilient to individual server connection failures - Use Promise.allSettled instead of Promise.all - Failed connections are logged as warnings but don't crash the UI - Only throws if ALL servers fail to connect 3. threejs-server: Add id to canvas for reliable screenshot masking - Added id="threejs-canvas" to the canvas element - Updated e2e test masks to use #threejs-canvas and .threejs-container - Fixes flaky Three.js screenshot comparisons in CI 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude <noreply@anthropic.com>
1 parent c25d464 commit 7eb98ad

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

examples/threejs-server/src/threejs-app.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ export default function ThreeJSApp({
188188
style={containerStyle}
189189
>
190190
<canvas
191+
id="threejs-canvas"
191192
ref={canvasRef}
192193
style={{
193194
width: "100%",

tests/e2e/servers.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ const DYNAMIC_MASKS: Record<string, string[]> = {
2121
"#memory-bar-fill", // Memory bar fill level
2222
"#info-uptime", // System uptime
2323
],
24-
threejs: ["canvas"], // 3D render canvas (dynamic animation)
24+
threejs: ["#threejs-canvas", ".threejs-container"], // 3D render canvas (dynamic animation)
2525
"wiki-explorer": ["#graph"], // Force-directed graph (dynamic layout)
2626
};
2727

0 commit comments

Comments
 (0)