Feature Mapping

[aindijrncom]

Hello, there seem to be some issues in the implementation of the feature mapping function.

cinolib/include/cinolib/feature_mapping.cpp

Lines 110 to 111 in d4659f1

	Octree o_curves;
	o_curves.build_from_mesh_polys(m_target);

cinolib/include/cinolib/feature_mapping.cpp

Line 136 in d4659f1

samples.push_back(o_curves.closest_point(p));

From the relevant description in include/cinolib/feature_mapping.h it can be seen that the implementation of this algorithm is based on "Feature Preserving Octree-Based Hexahedral Meshing" by Xifeng Gao, Hanxiao Shen, and Daniele Panozzo, published in Computer Graphics Forum (SGP) in 2019. However, in this paper, the definition of sampling points is on the source rather than on the target, as shown in the following figure.

But I'm not sure if the sampling points you used on the target mesh here were your deliberate choice or a mistake?
Thank you for your reply. Best regards.

[mlivesu]

Hi, on top of my head I just don't remember. I'd need to take a closer look at the code but this is a period dense of deadlines. I'll get back to you asap

[aindijrncom]

OK. Thank you for your reply.