Skip to content

Commit 72e38fb

Browse files
committed
fix: 优化 blank 函数,优化代码生成列表搜索条件判断
1 parent 1ee6770 commit 72e38fb

File tree

2 files changed

+16
-24
lines changed

2 files changed

+16
-24
lines changed

src/Generator/Traits/MapperGeneratorTraits.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ protected function getSearchPHPString($name, $mark, $comment): string
4848
return <<<php
4949
5050
// {$comment}
51-
if (blank(\$params['{$name}'])) {
51+
if ( isset(\$params['{$name}']) && blank(\$params['{$name}']) ) {
5252
\$query->where('{$name}', 'like', '%'.\$params['{$name}'].'%');
5353
}
5454
@@ -60,7 +60,7 @@ protected function getSearchPHPString($name, $mark, $comment): string
6060
return <<<php
6161
6262
// {$comment}
63-
if (blank(\$params['{$name}']) && is_array(\$params['{$name}']) && count(\$params['{$name}']) == 2) {
63+
if ( isset(\$params['{$name}']) && blank(\$params['{$name}']) && count(\$params['{$name}']) === 2 ) {
6464
\$query->whereBetween(
6565
'{$name}',
6666
[ \$params['{$name}'][0], \$params['{$name}'][1] ]
@@ -74,7 +74,7 @@ protected function getSearchPHPString($name, $mark, $comment): string
7474
return <<<php
7575
7676
// {$comment}
77-
if (blank(\$params['{$name}'])) {
77+
if ( isset(\$params['{$name}']) && blank(\$params['{$name}']) ) {
7878
\$query->whereIn('{$name}', \$params['{$name}']);
7979
}
8080
@@ -86,7 +86,7 @@ protected function getSearchPHPString($name, $mark, $comment): string
8686
return <<<php
8787
8888
// {$comment}
89-
if (blank(\$params['{$name}'])) {
89+
if ( isset(\$params['{$name}']) && blank(\$params['{$name}']) ) {
9090
\$query->whereNotIn('{$name}', \$params['{$name}']);
9191
}
9292
@@ -97,7 +97,7 @@ protected function getSearchPHPString($name, $mark, $comment): string
9797
return <<<php
9898
9999
// {$comment}
100-
if (blank(\$params['{$name}'])) {
100+
if ( isset(\$params['{$name}']) && blank(\$params['{$name}']) ) {
101101
\$query->where('{$name}', '{$mark}', \$params['{$name}']);
102102
}
103103

src/Helper/functions.php

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,7 @@ function add_queue(\App\System\Vo\AmqpQueueVo $amqpQueueVo): bool
261261
}
262262

263263
if (! function_exists('blank')) {
264+
264265
/**
265266
* 判断给定的值是否为空
266267
*
@@ -270,34 +271,25 @@ function add_queue(\App\System\Vo\AmqpQueueVo $amqpQueueVo): bool
270271
function blank(mixed $value): bool
271272
{
272273
if (is_null($value)) {
273-
return true;
274+
return false;
274275
}
275276

276277
if (is_string($value)) {
277-
return trim($value) === '';
278+
return ! (trim($value) === '');
278279
}
279280

280-
if (is_numeric($value) || is_bool($value)) {
281-
return false;
281+
if (is_bool($value)) {
282+
return true;
282283
}
283284

284-
if ($value instanceof Countable) {
285-
return count($value) === 0;
285+
if (is_array($value)) {
286+
return true;
286287
}
287288

288-
return empty($value);
289-
}
290-
}
289+
if ($value instanceof Countable) {
290+
return ! (count($value) === 0 );
291+
}
291292

292-
if (! function_exists('filled')) {
293-
/**
294-
* 判断给定的值是否不为空
295-
*
296-
* @param mixed $value
297-
* @return bool
298-
*/
299-
function filled(mixed $value): bool
300-
{
301-
return ! blank($value);
293+
return ! empty($value);
302294
}
303295
}

0 commit comments

Comments
 (0)