Skip to content

PRs quality #5612

Description

@aliheikal

It came to my attention that some users are submitting PRs that are resulting in inconsistent YAML files or spam, so I thought I should raise this as an issue. It is a quality matter from my point of view. How can we control this?

Example 1:

  1. I submitted this PR for Bot Framework Composer 1.1.1
  2. User with handle DW-42 submitted this update PR claiming it is to make things consistent, while this PR actually removed the word Corporation from the publisher, making it inconsistent, and also changed the homepage url to Bot Framework homepage instead of Bot Framework Composer homepage.
  3. I submitted this fix PR to fix the homepage url.

Example 2:

  1. User with handle DW-42 submitted this update PR claiming it is to make things consistent, while this PR actually removed the word Corporation from the publisher, making it inconsistent, and also changed the homepage url to a wrong one.
  2. I submitted this PR for Bot Framework Composer 1.2.1
  3. User with handle DW-42 submitted this update PR claiming it is to make things consistent, while this PR actually added the word Corporation to the publisher, contradicting their own previous PR of actually removing the word Corporation from the publisher, and also changed the homepage url to the documentation page instead of the homepage.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Issue-FeatureComplex enough to require an in depth planning process and actual budgeted, scheduled work.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions