Remove deprecated WebTest and TMI test methods#15525
Open
nohwnd wants to merge 5 commits intomicrosoft:mainfrom
Open
Remove deprecated WebTest and TMI test methods#15525nohwnd wants to merge 5 commits intomicrosoft:mainfrom
nohwnd wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Remove tests that were already [Ignore]d and marked with TODOs for removal: - WebTestRunAllTestsWithRunSettings (deprecated web test framework) - CodedWebTestRunAllTests (deprecated web test framework) - DiscoverTmiTestsWithOnlyPropertyValue (TMI no longer supported) Fixes microsoft#15489 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes acceptance/integration tests that were permanently ignored and explicitly marked for deletion due to deprecated/unsupported legacy frameworks (WebTest and TMI).
Changes:
- Deleted the ignored TMI discovery test from
TestCaseFilterTests.cs. - Deleted the ignored WebTest/CodedWebTest execution tests from
DifferentTestFrameworkSimpleTests.cs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TestCaseFilterTests.cs | Removes ignored TMI-based discovery test that targets an unsupported adapter/workflow. |
| test/Microsoft.TestPlatform.Acceptance.IntegrationTests/DifferentTestFrameworkSimpleTests.cs | Removes ignored WebTest/CodedWebTest tests tied to deprecated web test framework/assets. |
The System.IO using became unnecessary after removing the TMI test method which was the only consumer of Path.Combine/GetDirectoryName. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
needs removal of the projects as well, assigned |
No code references this package after removing the WebTest tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Removes permanently ignored/deprecated acceptance tests related to legacy WebTest and TMI adapters, along with the now-unneeded QTools assets dependency.
Changes:
- Deleted ignored TMI discovery test from
TestCaseFilterTests.cs. - Deleted ignored WebTest/CodedWebTest execution tests from
DifferentTestFrameworkSimpleTests.cs. - Removed
Microsoft.TestPlatform.QTools.Assetspackage reference from the acceptance test project.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/Microsoft.TestPlatform.Acceptance.IntegrationTests/TestCaseFilterTests.cs | Removes the deprecated/ignored TMI filter discovery test and related System.IO usage. |
| test/Microsoft.TestPlatform.Acceptance.IntegrationTests/Microsoft.TestPlatform.Acceptance.IntegrationTests.csproj | Drops the QTools assets package reference now that WebTest assets aren’t used. |
| test/Microsoft.TestPlatform.Acceptance.IntegrationTests/DifferentTestFrameworkSimpleTests.cs | Removes deprecated/ignored WebTest and CodedWebTest acceptance tests. |
Remove 4 [Ignore]d tests waiting for 'new host with CUIT removed'. CUIT (Coded UI Test) was deprecated and removed from Visual Studio years ago. These tests will never be un-ignored: - LegacySettingsWithScripts - LegacySettingsWithDeploymentItem - LegacySettingsTestTimeout - LegacySettingsAssemblyResolution The LegacySettingsUnitTestProject asset is kept as it is still used by the live LegacySettingsWithPlatform test. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove LegacySettingsWithPlatform (live), RunTestsWithTestSettingsInTpv2 and RunTestsWithTestSettingsInTpv0 (both [Ignore]d). Testsettings and TPv0 are deprecated and removed. Delete the LegacySettingsUnitTestProject test asset from disk and solution as it has no remaining consumers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove tests that were already [Ignore]d and marked with TODOs for removal:
WebTestRunAllTestsWithRunSettings- deprecated web test framework, already ignoredCodedWebTestRunAllTests- deprecated web test framework, already ignoredDiscoverTmiTestsWithOnlyPropertyValue- TMI no longer supported, already ignoredThese tests were permanently disabled and explicitly tagged for removal.
Fixes #15489