Refactor changedFilesSince to changedFiles with optional since parameter and Set for deduplication

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Author: Copilot

packages/cli/genaisrc/system.git.genai.mts

@@ -137,7 +137,7 @@ export default function (ctx: ChatGenerationContext) {
     })
 
     defTool(
-        "git_changed_files_since",
+        "git_changed_files",
         "Lists files that have been modified since a specific date or elapsed time.",
         {
             type: "object",
@@ -163,11 +163,11 @@ export default function (ctx: ChatGenerationContext) {
                     },
                 },
             },
-            required: ["since"],
         },
         async (args) => {
             const { since, paths, excludedPaths } = args
-            const files = await client.changedFilesSince(since, {
+            const files = await client.changedFiles({
+                since,
                 paths,
                 excludedPaths,
             })

packages/core/src/git.test.ts

@@ -3,21 +3,28 @@ import assert from "node:assert/strict"
 import { GitClient } from "./git"
 
 describe("GitClient", () => {
-    test("changedFilesSince method exists", () => {
+    test("changedFiles method exists", () => {
         const client = new GitClient(".")
-        assert(typeof client.changedFilesSince === "function", "changedFilesSince method should exist")
+        assert(typeof client.changedFiles === "function", "changedFiles method should exist")
     })
 
-    test("changedFilesSince method signature", () => {
+    test("changedFiles method signature", () => {
         const client = new GitClient(".")
         // Test that the method accepts the expected parameters
-        const method = client.changedFilesSince
-        assert.equal(method.length, 2, "changedFilesSince should accept 2 parameters")
+        const method = client.changedFiles
+        assert.equal(method.length, 1, "changedFiles should accept 1 parameter")
     })
 
-    test("changedFilesSince returns Promise", () => {
+    test("changedFiles returns Promise", () => {
         const client = new GitClient(".")
-        const result = client.changedFilesSince("1 hour ago")
-        assert(result instanceof Promise, "changedFilesSince should return a Promise")
+        const result = client.changedFiles({ since: "1 hour ago" })
+        assert(result instanceof Promise, "changedFiles should return a Promise")
+    })
+
+    test("changedFiles returns empty array when no since parameter", async () => {
+        const client = new GitClient(".")
+        const result = await client.changedFiles()
+        assert(Array.isArray(result), "changedFiles should return an array")
+        assert.equal(result.length, 0, "changedFiles should return empty array when no since parameter")
     })
 })

packages/core/src/git.ts

@@ -403,20 +403,24 @@ export class GitClient implements Git {
 
     /**
      * Lists files that have been modified since a specific date or elapsed time.
-     * @param since Date string (ISO format) or elapsed time (e.g., "2 hours ago", "1 day ago")
-     * @param options Optional settings such as paths and exclusions
+     * @param options Optional settings including since date, paths and exclusions
      * @returns {Promise<WorkspaceFile[]>} List of modified files since the specified time
      */
-    async changedFilesSince(
-        since: string,
-        options?: {
-            paths?: ElementOrArray<string>
-            excludedPaths?: ElementOrArray<string>
+    async changedFiles(options?: {
+        since?: string
+        paths?: ElementOrArray<string>
+        excludedPaths?: ElementOrArray<string>
+    }): Promise<WorkspaceFile[]> {
+        const { since, paths: optionPaths, excludedPaths: optionExcludedPaths } = options || {}
+        
+        if (!since) {
+            dbg(`no since parameter provided, returning empty list`)
+            return []
         }
-    ): Promise<WorkspaceFile[]> {
+        
         dbg(`listing files changed since: ${since}`)
-        const paths = arrayify(options?.paths, { filterEmpty: true })
-        const excludedPaths = await this.resolveExcludedPaths(options)
+        const paths = arrayify(optionPaths, { filterEmpty: true })
+        const excludedPaths = await this.resolveExcludedPaths({ excludedPaths: optionExcludedPaths })
 
         // Use git log to get files that changed since the specified date/time
         const args = ["log", "--name-only", "--pretty=format:", `--since=${since}`]
@@ -427,11 +431,12 @@ export class GitClient implements Git {
             label: `git list files changed since ${since}`,
         })
 
-        // Parse the output and remove duplicates
-        const filenames = res
-            .split("\n")
-            .filter((f) => f.trim() !== "")
-            .filter((f, index, arr) => arr.indexOf(f) === index) // Remove duplicates
+        // Parse the output and remove duplicates using Set
+        const uniqueFilenames = new Set(
+            res.split("\n")
+               .filter((f) => f.trim() !== "")
+        )
+        const filenames = Array.from(uniqueFilenames)
 
         dbg(`found ${filenames.length} files changed since ${since}`)
 

packages/core/src/types/prompt_template.d.ts

@@ -3258,16 +3258,13 @@ interface Git {
 
     /**
      * Lists files that have been modified since a specific date or elapsed time
-     * @param since Date string (ISO format) or elapsed time (e.g., "2 hours ago", "1 day ago")
-     * @param options Optional settings such as paths and exclusions
+     * @param options Optional settings including since date, paths and exclusions
      */
-    changedFilesSince(
-        since: string,
-        options?: {
-            paths?: ElementOrArray<string>
-            excludedPaths?: ElementOrArray<string>
-        }
-    ): Promise<WorkspaceFile[]>
+    changedFiles(options?: {
+        since?: string
+        paths?: ElementOrArray<string>
+        excludedPaths?: ElementOrArray<string>
+    }): Promise<WorkspaceFile[]>
 
     /**
      * Create a shallow git clone