Skip to content

Commit 0c2d24c

Browse files
authored
PowerToys Extension: Use project build because we don't need packagereference (#46080)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request At first version, tried to use the project reference instead of package reference, while it did not work in my local environment, so used package reference instead. While planned to project reference for many reasons like first day problem explosure in sdk, maintain the strict consistent winmd with the extension host. Hopefully to solve some of the extension not starting problem. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Built an installer and validated in my arm64 and x64 machine, works perfectly
1 parent b81ea23 commit 0c2d24c

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

Directory.Packages.props

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
<!-- Including MessagePack to force version, since it's used by StreamJsonRpc but contains vulnerabilities. After StreamJsonRpc updates the version of MessagePack, we can upgrade StreamJsonRpc instead. -->
4141
<PackageVersion Include="MessagePack" Version="3.1.3" />
4242
<PackageVersion Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="9.0.0" />
43-
<PackageVersion Include="Microsoft.CommandPalette.Extensions" Version="0.9.260303001" />
4443
<PackageVersion Include="Microsoft.Data.Sqlite" Version="9.0.10" />
4544
<!-- Including Microsoft.Bcl.AsyncInterfaces to force version, since it's used by Microsoft.SemanticKernel. -->
4645
<PackageVersion Include="Microsoft.Bcl.AsyncInterfaces" Version="9.0.10" />

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.PowerToys/Microsoft.CmdPal.Ext.PowerToys.csproj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@
3838

3939
<ItemGroup>
4040
<PackageReference Include="Microsoft.WindowsAppSDK" />
41-
<PackageReference Include="Microsoft.CommandPalette.Extensions" />
4241
<PackageReference Include="Microsoft.Windows.CsWin32">
4342
<PrivateAssets>all</PrivateAssets>
4443
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
@@ -56,6 +55,7 @@
5655
</PropertyGroup>
5756

5857
<ItemGroup>
58+
<ProjectReference Include="..\..\extensionsdk\Microsoft.CommandPalette.Extensions.Toolkit\Microsoft.CommandPalette.Extensions.Toolkit.csproj" />
5959
<ProjectReference Include="..\..\..\..\common\ManagedCommon\ManagedCommon.csproj" />
6060
<ProjectReference Include="..\..\..\..\common\Common.Search\Common.Search.csproj" />
6161
<ProjectReference Include="..\..\..\..\common\Common.UI\Common.UI.csproj" />

0 commit comments

Comments
 (0)