Single pak mode: mGBA often crashes after running for some time

[Sonic-The-Hedgehog-LNK1123]

mGBA version: 0.11-8847-84ed74802
OS: tested on Windows 10 and 7, both x64

Tested with the following games:

• Sonic Advance 1/2/3
• Kirby and the Amazing Mirror

Steps to reproduce:

1. Load a game
2. Open 1 to 3 additional multiplayer windows and boot the BIOS in them
3. Select a Single-pak game from the game's menu and confirm the connection
4. After the game is loaded, keep the game running for a while
5. If you are unlucky, mGBA crashes (sometimes after a long time, playing multiple sessions, sometimes it already crashes at the loading phase)

Try these steps a bunch of times and you will get a crash at some point

Sample crashes:

Problem signature:
  Problem Event Name:       APPCRASH
  Application Name:         mGBA.exe
  Application Version:      0.11.0.0
  Application Timestamp:    6893f010
  Fault Module Name:        mGBA.exe
  Fault Module Version:     0.11.0.0
  Fault Module Timestamp:   6893f010
  Exception Code:           40000015
  Exception Offset:         0000000001c32d1d
  OS Version:               6.1.7601.2.1.0.768.3
  Locale ID:                1033
  Additional Information 1: cf14
  Additional Information 2: cf14da71ec465122f13b3ebce66cd02b
  Additional Information 3: 825f
  Additional Information 4: 825f240434b498fe2e86ddfd0a069fc6

Problem signature:
  Problem Event Name:       APPCRASH
  Application Name:         mGBA.exe
  Application Version:      0.11.0.0
  Application Timestamp:    6893f010
  Fault Module Name:        mGBA.exe
  Fault Module Version:     0.11.0.0
  Fault Module Timestamp:   6893f010
  Exception Code:           40000015
  Exception Offset:         0000000001c32d29
  OS Version:               6.1.7601.2.1.0.768.3
  Locale ID:                1033
  Additional Information 1: cf14
  Additional Information 2: cf14da71ec465122f13b3ebce66cd02b
  Additional Information 3: 2733
  Additional Information 4: 2733d3bb011f4863b164d581385086f2

[endrift]

Hmm, I think those are assertion failures. I'll need to see if I can figure out which one is failing. I'm pretty sure @max-m has talked about getting these sometimes too.

[Sonic-The-Hedgehog-LNK1123]

The Windows 7 system displays a Runtime error message when the crash happens, like this:

But the Windows 10 system does not.

[Sonic-The-Hedgehog-LNK1123]

I ran some more tests and I got this crash in a multi-pak link too, I never got such crash in some older builds, even link sessions that were quite long.

[Testsr]

Happens to me as well, testing is a bit annoying with this.

[endrift]

I think this is fixed in 141a82e. Please retest.

[endrift]

Note that it popping up an error saying "the game has crashed" does not count as being fixed; that was just me turning the "hard" crash into a "soft" crash, not fixing the underlying bug.

[Sonic-The-Hedgehog-LNK1123]

I've just performed some tests on 141a82e and the results after running a multiplayer session for some time are:

• The following "crash" message pops up:

---------------------------
Crash
---------------------------
The game has crashed with the following error:

Multiplayer desynchronized: coordinator not waiting
---------------------------
OK   
---------------------------

• The log with default settings show the following 2 messages:

[FATAL] GBA Serial I/O:	Multiplayer desynchronized: coordinator not waiting
[FATAL] GBA Serial I/O:	Multiplayer desynchronized: player not asleep

• After clicking OK on the "crash" massage box the game continues running apparently fine, not even a communication error.

Issue #3550 might indeed have the same cause as this one, as after performing the player 1 reset, the same message box and log messages appear in that case.

[endrift]

Dang, so it does still reproduce. The easy way I was testing it is fixed, but I'll have to keep looking at it.