Fix PRODUCT skip threshold in test_c10d_torchcomms#2378
Open
pkourdis wants to merge 1 commit intometa-pytorch:mainfrom
Open
Fix PRODUCT skip threshold in test_c10d_torchcomms#2378pkourdis wants to merge 1 commit intometa-pytorch:mainfrom
pkourdis wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
The previous threshold (world_size > 34) targeted float32 overflow, but PRODUCT fails the exactness check well before that: world_size! is only exactly representable in float32 up to 12!. From 13! onward the expected Python int result and the float32 reduction differ causing assertEqual to spuriously fail. Lower the threshold to 12 and update the skip message.
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D103798974. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous threshold (
world_size > 34) targetedfloat32overflow, butPRODUCTfails the exactness check well before that:world_size!is only exactly representable infloat32up to12!. From13!onward the expected Python int result and thefloat32reduction differ causingassertEqualto spuriously fail. Lower the threshold to 12 and update the skip message.