PERF: Use .Count instead of .Any to check for existence

Author: mdesalvo

RDFSharp/Query/Mirella/Algebra/Filters/RDFExistsFilter.cs

@@ -90,13 +90,13 @@ internal override bool ApplyFilter(DataRow row, bool applyNegation)
             else
             {
                 EnumerableRowCollection<DataRow> patternResultsEnumerable = PatternResults?.AsEnumerable();
-                if (patternResultsEnumerable?.Any() ?? false)
+                if (patternResultsEnumerable?.Count() > 0)
                 {
                     #region Subject
                     bool subjectCompared = false;                    
                     if (Pattern.Subject is RDFVariable
-                            && PatternResults.Columns.Contains(subjectString)
-                                && row.Table.Columns.Contains(subjectString))
+                         && PatternResults.Columns.Contains(subjectString)
+                         && row.Table.Columns.Contains(subjectString))
                     {
                         //In case of emptiness the solution is compatible, otherwise proceed with comparison
                         if (!row.IsNull(subjectString))
@@ -114,8 +114,8 @@ internal override bool ApplyFilter(DataRow row, bool applyNegation)
                     #region Predicate
                     bool predicateCompared = false;
                     if (Pattern.Predicate is RDFVariable
-                            && PatternResults.Columns.Contains(predicateString)
-                                && row.Table.Columns.Contains(predicateString))
+                         && PatternResults.Columns.Contains(predicateString)
+                         && row.Table.Columns.Contains(predicateString))
                     {
                         //In case of emptiness the solution is compatible, otherwise proceed with comparison
                         if (!row.IsNull(predicateString))
@@ -133,8 +133,8 @@ internal override bool ApplyFilter(DataRow row, bool applyNegation)
                     #region Object
                     bool objectCompared = false;
                     if (Pattern.Object is RDFVariable
-                            && PatternResults.Columns.Contains(objectString)
-                                && row.Table.Columns.Contains(objectString))
+                         && PatternResults.Columns.Contains(objectString)
+                         && row.Table.Columns.Contains(objectString))
                     {
                         //In case of emptiness the solution is compatible, otherwise proceed with comparison
                         if (!row.IsNull(objectString))
@@ -150,7 +150,7 @@ internal override bool ApplyFilter(DataRow row, bool applyNegation)
                     #endregion
 
                     //Verify filter's response on the pattern resultset
-                    if ((subjectCompared || predicateCompared || objectCompared) && patternResultsEnumerable.Any())
+                    if ((subjectCompared || predicateCompared || objectCompared) && patternResultsEnumerable.Count() > 0)
                         keepRow = true;
                 }
             }

RDFSharp/Query/Mirella/Algebra/Filters/RDFValuesFilter.cs

@@ -68,7 +68,7 @@ internal override bool ApplyFilter(DataRow row, bool applyNegation)
 
             //Check is performed only on columns found as bindings in the filter
             List<string> filterColumns = Values.Bindings.Keys.Where(k => row.Table.Columns.Contains(k)).ToList();
-            if (filterColumns.Any())
+            if (filterColumns.Count > 0)
             {
                 //Get the enumerable representation of the filter table
                 EnumerableRowCollection<DataRow> valuesTableEnumerable = ValuesTable.AsEnumerable();
@@ -85,7 +85,7 @@ internal override bool ApplyFilter(DataRow row, bool applyNegation)
                 });
 
                 //Analyze the response of the check
-                keepRow = valuesTableEnumerable.Any();
+                keepRow = valuesTableEnumerable.Count() > 0;
             }
 
             //Apply the eventual negation

RDFSharp/Query/Mirella/Algebra/Modifiers/RDFGroupByModifier.cs

@@ -119,19 +119,19 @@ private void ConsistencyChecks(DataTable table)
             //Every partition variable must be found in the working table as a column
             IEnumerable<string> unavailablePartitionVariables = PartitionVariables.Where(pv => !table.Columns.Contains(pv.ToString()))
                                                                                   .Select(pv => pv.ToString());
-            if (unavailablePartitionVariables.Any())
+            if (unavailablePartitionVariables.Count() > 0)
                 throw new RDFQueryException(string.Format("Cannot apply GroupBy modifier because the working table does not contain the following columns needed for partitioning: {0}", string.Join(",", unavailablePartitionVariables.Distinct())));
 
             //Every aggregator variable must be found in the working table as a column
             IEnumerable<string> unavailableAggregatorVariables = Aggregators.Where(ag => !table.Columns.Contains(ag.AggregatorVariable.ToString()))
                                                                             .Select(ag => ag.AggregatorVariable.ToString());
-            if (unavailableAggregatorVariables.Any())
+            if (unavailableAggregatorVariables.Count() > 0)
                 throw new RDFQueryException(string.Format("Cannot apply GroupBy modifier because the working table does not contain the following columns needed for aggregation: {0}", string.Join(",", unavailableAggregatorVariables.Distinct())));
 
             //There should NOT be intersection between partition variables (GroupBy) and projection variables (Aggregators)
             IEnumerable<string> commonPartitionProjectionVariables = PartitionVariables.Where(pv => Aggregators.Any(ag => (!(ag is RDFPartitionAggregator)) && pv.Equals(ag.ProjectionVariable)))
                                                                                        .Select(pav => pav.ToString());
-            if (commonPartitionProjectionVariables.Any())
+            if (commonPartitionProjectionVariables.Count() > 0)
                 throw new RDFQueryException(string.Format("Cannot apply GroupBy modifier because the following variables have been specified both for partitioning (in GroupBy) and projection (in Aggregator): {0}", string.Join(",", commonPartitionProjectionVariables.Distinct())));
         }
 

RDFSharp/Query/Mirella/Algebra/RDFValues.cs

@@ -76,7 +76,7 @@ public RDFValues AddColumn(RDFVariable variable, List<RDFPatternMember> bindings
 
                 //Populate bindings of the given variable
                 //(null indicates the special UNDEF binding)
-                if (bindings?.Any() ?? false)
+                if (bindings?.Count > 0)
                     bindings.ForEach(b => Bindings[variableString].Add((b is RDFResource || b is RDFLiteral) ? b : null));
                 else
                     Bindings[variableString].Add(null);

RDFSharp/Query/Mirella/RDFOperationEngine.cs

@@ -369,7 +369,7 @@ private RDFConstructQueryResult ExecuteConstructQueryFromOperation(RDFOperation
             DataTable resultTable = new DataTable();
             RDFConstructQueryResult constructResult = new RDFConstructQueryResult();
             List<RDFQueryMember> evaluableQueryMembers = operation.GetEvaluableQueryMembers().ToList();
-            if (evaluableQueryMembers.Any())
+            if (evaluableQueryMembers.Count > 0)
             {
                 //Iterate the evaluable members of the operation
                 EvaluateQueryMembers(evaluableQueryMembers, datasource);

RDFSharp/Query/Mirella/RDFOperationPrinter.cs

@@ -206,7 +206,7 @@ internal static string PrintClearOperation(RDFClearOperation clearOperation)
         private static string PrintPrefixes(List<RDFNamespace> operationPrefixes)
         {
             StringBuilder sb = new StringBuilder();
-            if (operationPrefixes.Any())
+            if (operationPrefixes.Count > 0)
             {
                 operationPrefixes.ForEach(pf => sb.AppendLine(string.Concat("PREFIX ", pf.NamespacePrefix, ": <", pf.NamespaceUri.ToString(), ">")));
                 sb.AppendLine();

RDFSharp/Query/Mirella/RDFQueryEngine.cs

@@ -88,7 +88,7 @@ internal RDFSelectQueryResult EvaluateSelectQuery(RDFSelectQuery selectQuery, RD
             DataTable queryResultTable = new DataTable();
             RDFSelectQueryResult queryResult = new RDFSelectQueryResult();
             List<RDFQueryMember> evaluableQueryMembers = selectQuery.GetEvaluableQueryMembers().ToList();
-            if (evaluableQueryMembers.Any())
+            if (evaluableQueryMembers.Count > 0)
             {
                 //Iterate the evaluable members of the query
                 EvaluateQueryMembers(evaluableQueryMembers, datasource);
@@ -131,7 +131,7 @@ DataTable FillDescribeTerms(DataTable qResultTable)
             DataTable queryResultTable = new DataTable();
             RDFDescribeQueryResult queryResult = new RDFDescribeQueryResult();
             List<RDFQueryMember> evaluableQueryMembers = describeQuery.GetEvaluableQueryMembers().ToList();
-            if (evaluableQueryMembers.Any())
+            if (evaluableQueryMembers.Count > 0)
             {
                 //Iterate the evaluable members of the query
                 EvaluateQueryMembers(evaluableQueryMembers, datasource);
@@ -157,7 +157,7 @@ internal RDFConstructQueryResult EvaluateConstructQuery(RDFConstructQuery constr
             DataTable queryResultTable = new DataTable();
             RDFConstructQueryResult constructResult = new RDFConstructQueryResult();
             List<RDFQueryMember> evaluableQueryMembers = constructQuery.GetEvaluableQueryMembers().ToList();
-            if (evaluableQueryMembers.Any())
+            if (evaluableQueryMembers.Count > 0)
             {
                 //Iterate the evaluable members of the query
                 EvaluateQueryMembers(evaluableQueryMembers, datasource);
@@ -182,7 +182,7 @@ internal RDFAskQueryResult EvaluateAskQuery(RDFAskQuery askQuery, RDFDataSource
         {
             RDFAskQueryResult askResult = new RDFAskQueryResult();
             List<RDFQueryMember> evaluableQueryMembers = askQuery.GetEvaluableQueryMembers().ToList();
-            if (evaluableQueryMembers.Any())
+            if (evaluableQueryMembers.Count > 0)
             {
                 //Iterate the evaluable members of the query
                 EvaluateQueryMembers(evaluableQueryMembers, datasource);
@@ -386,7 +386,7 @@ internal void EvaluatePatternGroup(RDFPatternGroup patternGroup, RDFDataSource d
         internal void FinalizePatternGroup(RDFPatternGroup patternGroup)
         {
             List<RDFPatternGroupMember> evaluablePGMembers = patternGroup.GetEvaluablePatternGroupMembers().ToList();
-            if (evaluablePGMembers.Any())
+            if (evaluablePGMembers.Count > 0)
             {
                 //Populate patternGroup result table
                 DataTable patternGroupResultTable = CombineTables(PatternGroupMemberResultTables[patternGroup.QueryMemberID]);
@@ -422,7 +422,7 @@ internal void ApplyFilters(RDFPatternGroup patternGroup)
         {
             List<RDFPatternGroupMember> evaluablePatternGroupMembers = patternGroup.GetEvaluablePatternGroupMembers().ToList();
             List<RDFFilter> filters = patternGroup.GetFilters().ToList();
-            if (evaluablePatternGroupMembers.Any() && filters.Any())
+            if (evaluablePatternGroupMembers.Count > 0 && filters.Count > 0)
             {
                 DataTable filteredTable = QueryMemberResultTables[patternGroup.QueryMemberID].Clone();
                 IEnumerator rowsEnum = QueryMemberResultTables[patternGroup.QueryMemberID].Rows.GetEnumerator();
@@ -656,7 +656,7 @@ internal DataTable DescribeTerms(RDFDescribeQuery describeQuery, RDFDataSource d
             AddColumn(result, "?OBJECT");
 
             //In case of "DESCRIBE *" query, all the variables must be considered describe terms
-            if (!describeQuery.DescribeTerms.Any())
+            if (describeQuery.DescribeTerms.Count == 0)
                 FetchDescribeVariablesFromQueryMembers(describeQuery, describeQuery.GetEvaluableQueryMembers());
 
             //Iterate the describe terms of the query
@@ -1719,7 +1719,7 @@ bool CheckJoin(DataRow leftRow, DataRow rightRow, string commonColumn)
                 List<DataRow> relatedRowsList = relatedRows.ToList();
 
                 //Relation HAS found data => proceed with outer-join
-                if (relatedRowsList.Any())
+                if (relatedRowsList.Count > 0)
                 {
                     foreach (DataRow relatedRow in relatedRowsList)
                     {
@@ -1979,15 +1979,15 @@ internal static DataTable ProjectTable(RDFSelectQuery query, DataTable table)
             ProjectExpressions(query, table);
 
             //Execute configured sort modifiers
-            IEnumerable<RDFOrderByModifier> orderbyModifiers = query.GetModifiers().OfType<RDFOrderByModifier>();
-            if (orderbyModifiers.Any())
+            RDFOrderByModifier[] orderbyModifiers = query.GetModifiers().OfType<RDFOrderByModifier>().ToArray();
+            if (orderbyModifiers.Length > 0)
             {
                 table = orderbyModifiers.Aggregate(table, (current, modifier) => modifier.ApplyModifier(current));
                 table = table.DefaultView.ToTable();
             }
 
             //Execute projection algorythm
-            if (query.ProjectionVars.Any())
+            if (query.ProjectionVars.Count > 0)
             {
                 //Remove non-projection variables
                 DataColumn[] tableColumns = table.Columns.OfType<DataColumn>().ToArray();

RDFSharp/Query/Mirella/RDFQueryPrinter.cs

@@ -93,7 +93,7 @@ int subqueryUnionOrMinusSpacesFunc(bool unionOrMinus)
             //Query hasn't GroupBy modifier => respect given projections
             else
             {
-                if (!selectQuery.ProjectionVars.Any())
+                if (selectQuery.ProjectionVars.Count == 0)
                     sb.Append(" *");
                 else
                 {
@@ -181,7 +181,7 @@ internal static string PrintDescribeQuery(RDFDescribeQuery describeQuery)
 
             #region DESCRIBE
             sb.Append("DESCRIBE");
-            if (describeQuery.DescribeTerms.Any())
+            if (describeQuery.DescribeTerms.Count > 0)
                 describeQuery.DescribeTerms.ForEach(dt => sb.Append(string.Concat(" ", PrintPatternMember(dt, describeQuery.Prefixes))));
             else
                 sb.Append(" *");
@@ -287,7 +287,7 @@ internal static string PrintAskQuery(RDFAskQuery askQuery)
         internal static List<RDFNamespace> PrintPrefixes(RDFQuery query, StringBuilder sb, bool enablePrinting)
         {
             List<RDFNamespace> prefixes = query.GetPrefixes();
-            if (enablePrinting && prefixes.Any())
+            if (enablePrinting && prefixes.Count > 0)
             {
                 prefixes.ForEach(pf => sb.AppendLine(string.Concat("PREFIX ", pf.NamespacePrefix, ": <", pf.NamespaceUri.ToString(), ">")));
                 sb.AppendLine();