Skip to content

Commit ac9a0a3

Browse files
worktrunk-botclaude
andcommitted
fix(skills): prevent premature thread resolution on self-authored PRs
The review bot incorrectly resolved its own technically-correct suggestion on PR #1583. It had correctly identified that linked worktrees can be on different mount points (EXDEV on rename), but in a later incremental review run it accepted the author's less accurate doc comment claiming ".git/ is always on the same filesystem" and resolved the thread. Add guidance to Step 6 (thread resolution) requiring: - Verification that the substance was addressed, not just reworded - Extra skepticism on self-authored PRs where the bot is both author and reviewer, creating a bias toward accepting its own code's claims Evidence: run 23182191893, PR #1583, session e2cae4a2 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 5eb7a76 commit ac9a0a3

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

.claude/skills/review-pr/SKILL.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,17 @@ After approving or staying silent, monitor CI using the approach from
318318
After submitting the review, check if any unresolved bot threads have been
319319
addressed by the new changes. Resolve threads where the suggestion was applied.
320320

321+
**Only resolve if the substance was addressed.** Read both the suggestion and the
322+
new code — if the author took a different approach, verify its technical accuracy
323+
before resolving. "Different wording" is not "addressed" when the new wording is
324+
less accurate than the suggestion. When in doubt, leave the thread open for a
325+
human reviewer.
326+
327+
**Self-authored PRs are especially risky.** When the bot is both author and
328+
reviewer, there is a bias toward accepting the code's own claims. Treat
329+
self-authored thread resolution with extra skepticism — read the code and verify
330+
the claim independently rather than trusting the doc comment or commit message.
331+
321332
```bash
322333
cat > /tmp/review-threads.graphql << 'GRAPHQL'
323334
query($owner: String!, $repo: String!, $number: Int!) {

0 commit comments

Comments
 (0)