Merge pull request #709 from marp-team/docker-set-xdg-directories

Fix failure to launch Chromium if the user specified by MARP_USER env does not exist in the Docker container image

Author: yhatt

CHANGELOG.md

@@ -21,6 +21,7 @@
 
 - Fix ambiguous CLI arguments parsing for `--output` ([#684](https://github.com/marp-team/marp-cli/issues/684), [#685](https://github.com/marp-team/marp-cli/pull/685))
 - Make more sensible error detection while connecting to browser ([#706](https://github.com/marp-team/marp-cli/pull/706))
+- Fix failure to launch Chromium if the user specified by `MARP_USER` env does not exist in the Docker container image ([#702](https://github.com/marp-team/marp-cli/issues/702), [#709](https://github.com/marp-team/marp-cli/pull/709))
 
 ## v4.2.3 - 2025-08-09
 

Dockerfile

@@ -27,7 +27,7 @@ RUN apt update && \
   npm cache clean --force
 
 # Set environments
-ENV MARP_USER=marp:marp PATH=$PATH:/home/marp/.cli CHROME_PATH=/usr/local/bin/chrome
+ENV MARP_USER=marp:marp PATH=$PATH:/home/marp/.cli CHROME_PATH=/usr/local/bin/chrome CHROME_CONFIG_HOME=/tmp/marp-config
 
 # Copy Marp CLI files
 USER marp

package-lock.json

@@ -14,27 +14,17 @@ export class ChromeBrowser extends Browser {
   protected async launchPuppeteer(
     opts: Omit<LaunchOptions, 'userDataDir'> // userDataDir cannot overload in current implementation
   ): Promise<PuppeteerBrowser> {
-    const ignoreDefaultArgsSet = new Set(
-      typeof opts.ignoreDefaultArgs === 'object' ? opts.ignoreDefaultArgs : []
-    )
-
-    // Escape hatch for force-extensions policy for Chrome enterprise
-    // https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md#chrome-headless-doesnt-launch-on-windows
-    // https://github.com/marp-team/marp-cli/issues/231
-    if (process.env.CHROME_ENABLE_EXTENSIONS) {
-      ignoreDefaultArgsSet.add('--disable-extensions')
-    }
-
     const baseOpts = await this.generateLaunchOptions({
+      // Escape hatch for force-extensions policy for Chrome enterprise
+      // https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md#chrome-headless-doesnt-launch-on-windows
+      // https://github.com/marp-team/marp-cli/issues/231
+      enableExtensions: !!process.env.CHROME_ENABLE_EXTENSIONS,
       headless: this.puppeteerHeadless(),
       pipe: await this.puppeteerPipe(),
       // userDataDir: await this.puppeteerDataDir(), // userDataDir will set in args option due to wrong path normalization in WSL
       ...opts,
       userDataDir: undefined,
       args: await this.puppeteerArgs(opts.args ?? []),
-      ignoreDefaultArgs: opts.ignoreDefaultArgs === true || [
-        ...ignoreDefaultArgsSet,
-      ],
     })
 
     const tryLaunch = async (

src/browser/browsers/chrome.ts

@@ -38,6 +38,8 @@ export function error(
   throw cliError
 }
 
+// TODO: Use Error.isError instead, in Node.js v24.3+
+// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/isError
 export const isError = (e: unknown): e is NodeJS.ErrnoException => {
   if (e instanceof Error) return true
 

src/error.ts

@@ -71,7 +71,7 @@ describe('ChromeBrowser', () => {
             args: expect.arrayContaining([
               expect.stringMatching(/^--user-data-dir=/),
             ]),
-            ignoreDefaultArgs: [],
+            enableExtensions: false,
           })
         )
       })
@@ -145,41 +145,34 @@ describe('ChromeBrowser', () => {
       })
 
       describe('Disabling extensions', () => {
-        it('ignores --disable-extensions argument if CHROME_ENABLE_EXTENSIONS environment variable is defined', async () => {
+        it('enables extensions if CHROME_ENABLE_EXTENSIONS environment variable is defined', async () => {
           process.env.CHROME_ENABLE_EXTENSIONS = '1'
           await new ChromeBrowser({ path: '/path/to/chrome' }).launch()
 
           expect(puppeteer.launch).toHaveBeenCalledWith(
-            expect.objectContaining({
-              ignoreDefaultArgs: expect.arrayContaining([
-                '--disable-extensions',
-              ]),
-            })
+            expect.objectContaining({ enableExtensions: true })
           )
         })
 
-        it('does not ignore --disable-extensions argument if CHROME_ENABLE_EXTENSIONS environment variable is empty', async () => {
+        it('does not enable extensions if CHROME_ENABLE_EXTENSIONS environment variable is empty', async () => {
           process.env.CHROME_ENABLE_EXTENSIONS = ''
           await new ChromeBrowser({ path: '/path/to/chrome' }).launch()
 
           expect(puppeteer.launch).toHaveBeenCalledWith(
-            expect.objectContaining({ ignoreDefaultArgs: [] })
+            expect.objectContaining({ enableExtensions: false })
           )
         })
 
-        it('merges ignoreDefaultArgs if passed extra ignore args', async () => {
+        it('passes through ignoreDefaultArgs if passed extra ignore args', async () => {
           process.env.CHROME_ENABLE_EXTENSIONS = 'true'
           await new ChromeBrowser({ path: '/path/to/chrome' }).launch({
             ignoreDefaultArgs: ['--foo', '--bar'],
           })
 
           expect(puppeteer.launch).toHaveBeenCalledWith(
             expect.objectContaining({
-              ignoreDefaultArgs: expect.arrayContaining([
-                '--disable-extensions',
-                '--foo',
-                '--bar',
-              ]),
+              enableExtensions: true,
+              ignoreDefaultArgs: expect.arrayContaining(['--foo', '--bar']),
             })
           )
         })
@@ -191,22 +184,21 @@ describe('ChromeBrowser', () => {
           })
 
           expect(puppeteer.launch).toHaveBeenCalledWith(
-            expect.objectContaining({ ignoreDefaultArgs: true })
+            expect.objectContaining({
+              enableExtensions: true,
+              ignoreDefaultArgs: true,
+            })
           )
         })
 
-        it('keeps ignoring --disable-extensions argument even if explicitly passed ignoreDefaultArgs as false', async () => {
+        it('enables extensions even if explicitly passed ignoreDefaultArgs as false', async () => {
           process.env.CHROME_ENABLE_EXTENSIONS = 'enabled'
           await new ChromeBrowser({ path: '/path/to/chrome' }).launch({
             ignoreDefaultArgs: false,
           })
 
           expect(puppeteer.launch).toHaveBeenCalledWith(
-            expect.objectContaining({
-              ignoreDefaultArgs: expect.arrayContaining([
-                '--disable-extensions',
-              ]),
-            })
+            expect.objectContaining({ enableExtensions: true })
           )
         })
       })