Use unique_ptr as input to Tube

Author: markaren

examples/geometries/geometries.cpp

@@ -98,8 +98,8 @@ namespace {
     }
 
     auto createTube(const std::shared_ptr<Material>& m1, const std::shared_ptr<LineBasicMaterial>& m2) {
-        const auto curve = std::make_shared<CustomSineCurve>(0.5f);
-        const auto geometry = TubeGeometry::create(curve, 32, 0.1f);
+        auto curve = std::make_unique<CustomSineCurve>(0.5f);
+        const auto geometry = TubeGeometry::create(std::move(curve), 32, 0.1f);
         auto mesh = Mesh::create(geometry, m1);
         const auto wire = LineSegments::create(WireframeGeometry::create(*geometry), m2);
         mesh->add(wire);

examples/geometries/tube_geometry.cpp

@@ -24,9 +24,9 @@ namespace {
     };
 
     auto makeTubeMesh() {
-        const auto curve = std::make_shared<CustomSineCurve>(10.f);
+        auto curve = std::make_unique<CustomSineCurve>(10.f);
 
-        const auto geometry = TubeGeometry::create(curve);
+        const auto geometry = TubeGeometry::create(std::move(curve));
         const auto material = MeshBasicMaterial::create(
                 {{"color", 0xff0000},
                  {"side", Side::Double}});

include/threepp/geometries/TubeGeometry.hpp

@@ -25,16 +25,16 @@ namespace threepp {
         };
 
         const float radius;
-        const std::shared_ptr<Curve3> path;
+        const std::unique_ptr<Curve3> path;
 
         [[nodiscard]] std::string type() const override;
 
         static std::shared_ptr<TubeGeometry> create(
-                const std::shared_ptr<Curve3>& path,
+                std::unique_ptr<Curve3> path,
                 const Params& params);
 
         static std::shared_ptr<TubeGeometry> create(
-                const std::shared_ptr<Curve3>& path,
+                std::unique_ptr<Curve3> path,
                 unsigned int tubularSegments = 64,
                 float radius = 1,
                 unsigned int radialSegments = 16,
@@ -43,7 +43,7 @@ namespace threepp {
     private:
         FrenetFrames frames;
 
-        TubeGeometry(std::shared_ptr<Curve3> path, const Params& params);
+        TubeGeometry(std::unique_ptr<Curve3> path, const Params& params);
     };
 
 }// namespace threepp

src/threepp/geometries/TubeGeometry.cpp

@@ -7,7 +7,7 @@
 
 using namespace threepp;
 
-TubeGeometry::TubeGeometry(std::shared_ptr<Curve3> path, const Params& params)
+TubeGeometry::TubeGeometry(std::unique_ptr<Curve3> path, const Params& params)
     : radius(params.radius), path(std::move(path)) {
 
     this->frames = FrenetFrames::compute(*this->path, params.tubularSegments, params.closed);
@@ -135,14 +135,14 @@ std::string TubeGeometry::type() const {
     return "TubeGeometry";
 }
 
-std::shared_ptr<TubeGeometry> TubeGeometry::create(const std::shared_ptr<Curve3>& path, const Params& params) {
+std::shared_ptr<TubeGeometry> TubeGeometry::create(std::unique_ptr<Curve3> path, const Params& params) {
 
-    return std::shared_ptr<TubeGeometry>(new TubeGeometry(path, params));
+    return std::shared_ptr<TubeGeometry>(new TubeGeometry(std::move(path), params));
 }
 
-std::shared_ptr<TubeGeometry> TubeGeometry::create(const std::shared_ptr<Curve3>& path, unsigned int tubularSegments, float radius, unsigned int radialSegments, bool closed) {
+std::shared_ptr<TubeGeometry> TubeGeometry::create(std::unique_ptr<Curve3> path, unsigned int tubularSegments, float radius, unsigned int radialSegments, bool closed) {
 
-    return create(path, Params(tubularSegments, radius, radialSegments, closed));
+    return create(std::move(path), Params(tubularSegments, radius, radialSegments, closed));
 }
 
 TubeGeometry::Params::Params(unsigned int tubularSegments, float radius, unsigned int radialSegments, bool closed)