Skip to content

Commit 76f2c91

Browse files
committed
Add error handling to serial.connectAndOpen
Wrap serial.connectAndOpen calls in try/catch across multiple WebSerial sketches to prevent uncaught exceptions on connection failure and log errors to the console. Behavior is unchanged on successful connect; failures now produce a console error message.
1 parent adcb5fe commit 76f2c91

5 files changed

Lines changed: 26 additions & 6 deletions

File tree

WebSerial/ml5js/NoseTracker/sketch.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,10 @@ function drawEye(x, y) {
202202

203203
function mouseClicked() {
204204
if (!serial.isOpen()) {
205-
serial.connectAndOpen(null, serialOptions);
205+
try {
206+
serial.connectAndOpen(null, serialOptions);
207+
} catch (error) {
208+
console.error("Serial connection failed:", error);
209+
}
206210
}
207211
}

WebSerial/p5js/CircleSizeIn/sketch.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,10 @@ function draw() {
118118

119119
function mouseClicked() {
120120
if (!serial.isOpen()) {
121-
serial.connectAndOpen(null, serialOptions);
121+
try {
122+
serial.connectAndOpen(null, serialOptions);
123+
} catch (error) {
124+
console.error("Serial connection failed:", error);
125+
}
122126
}
123-
}
127+
}

WebSerial/p5js/CircleSizeInDemo/sketch.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,10 @@ function onSerialDataReceived(eventSender, newData) {
6565

6666
function mouseClicked() {
6767
if (!serial.isOpen()) {
68-
serial.connectAndOpen(null, serialOptions);
68+
try {
69+
serial.connectAndOpen(null, serialOptions);
70+
} catch (error) {
71+
console.error("Serial connection failed:", error);
72+
}
6973
}
7074
}

WebSerial/p5js/GraphIn/sketch.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,10 @@ function onSerialDataReceived(eventSender, newData) {
7777

7878
function mouseClicked() {
7979
if (!serial.isOpen()) {
80-
serial.connectAndOpen(null, serialOptions);
80+
try {
81+
serial.connectAndOpen(null, serialOptions);
82+
} catch (error) {
83+
console.error("Serial connection failed:", error);
84+
}
8185
}
8286
}

WebSerial/p5js/XMouseSerialOut/sketch.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,10 @@ function onSerialDataReceived(eventSender, newData) {
106106
*/
107107
function mouseClicked() {
108108
if (!serial.isOpen()) {
109-
serial.connectAndOpen(null, serialOptions);
109+
try {
110+
serial.connectAndOpen(null, serialOptions);
111+
} catch (error) {
112+
console.error("Serial connection failed:", error);
113+
}
110114
}
111115
}

0 commit comments

Comments
 (0)