CloneDlg: remove signal/slot connections of steps

The "finished" status of a step is artificially generated through it's progress (>=100%). The progress dialog now does this by itself.

Author: antis81

Modules/Remotes/CloneRepositoryDlg.cpp

@@ -174,8 +174,6 @@ void CloneDlg::accept()
     if (!clone->bare()) {
           steps << ProgressDlg::StepInfo{ QStringLiteral("checkout"),
                    tr("Checkout the worktree.") };
-          connect( clone, &Git::CloneOperation::doneCheckout,
-                   this,  &CloneDlg::doneCheckout );
     }
 
     mProgress->addActivity(tr("Clone <b>%1</b> to <b>%2</b>")
@@ -187,29 +185,10 @@ void CloneDlg::accept()
              this,  &CloneDlg::onTransportProgress );
     connect( clone, &Git::CloneOperation::checkoutProgress,
              this,  &CloneDlg::onCheckoutProgress );
-    connect( clone, &Git::CloneOperation::doneDownloading,
-             this,  &CloneDlg::doneDownload );
-    connect( clone, &Git::CloneOperation::doneIndexing,
-             this,  &CloneDlg::doneIndexing );
 
     clone->execute();
 }
 
-void CloneDlg::doneDownload()
-{
-    mProgress->finished(sender(), QStringLiteral("transfer"));
-}
-
-void CloneDlg::doneIndexing()
-{
-    mProgress->finished(sender(), QStringLiteral("index"));
-}
-
-void CloneDlg::doneCheckout()
-{
-    mProgress->finished(sender(), QStringLiteral("checkout"));
-}
-
 void CloneDlg::rootCloneFinished()
 {
     Git::BaseOperation* operation = static_cast<Git::BaseOperation*>( sender() );

Modules/Remotes/CloneRepositoryDlg.hpp

@@ -84,9 +84,6 @@ private slots:
     void checkValid();
 
     void beginDownloading();
-    void doneDownload();
-    void doneIndexing();
-    void doneCheckout();
     void rootCloneFinished();
 
     void onCheckoutProgress(const QString& fileName,