More warning workarounds

Author: mabraham

src/gromacs/fileio/trxio.cpp

@@ -844,7 +844,7 @@ bool read_next_frame(const gmx_output_env_t* oenv, t_trxstatus* status, t_trxfra
 
     const bool buildIsDoublePrecision = GMX_DOUBLE;
     const bool compareTimesAsDouble =
-            buildIsDoublePrecision && (status->fio ? gmx_fio_is_double(status->fio) : false);
+        ((buildIsDoublePrecision) && (status->fio ? gmx_fio_is_double(status->fio) : false);
     do
     {
         clear_trxframe(fr, FALSE);

src/gromacs/hardware/detecthardware.cpp

@@ -149,7 +149,7 @@ static DeviceDetectionResult detectAllDeviceInformation(const PhysicalNodeCommun
      * and send the information to the other ranks over MPI. This
      * avoids creating a start-up bottleneck with each MPI rank on a
      * node making the same GPU API calls. */
-    constexpr bool allRanksMustDetectGpus = (GMX_GPU_OPENCL != 0 || GMX_GPU_SYCL != 0);
+    constexpr bool allRanksMustDetectGpus = ((GMX_GPU_OPENCL != 0) || (GMX_GPU_SYCL != 0));
     bool           gpusCanBeDetected      = false;
     if (isMainRankOfPhysicalNode || allRanksMustDetectGpus)
     {

src/gromacs/mdrun/runner.cpp

@@ -316,10 +316,14 @@ static DevelopmentFeatureFlags manageDevelopmentFeatures(const gmx::MDLogger& md
             (pmeRunMode == PmeRunMode::GPU || pmeRunMode == PmeRunMode::Mixed)
             && ((numRanksPerSimulation > 1 && numPmeRanksPerSimulation == 0)
                 || numPmeRanksPerSimulation > 1);
-    const bool pmeGpuDecompositionSupported =
-            canUseGpuAwareMpi && GpuConfigurationCapabilities::PpPmeDirectComm
-            && ((GpuConfigurationCapabilities::PmeDecomposition && pmeRunMode == PmeRunMode::GPU)
-                || (GpuConfigurationCapabilities::Pme && pmeRunMode == PmeRunMode::Mixed));
+    const bool runConfigurationCouldUsePmeDecompositionOnGpu =
+            (GpuConfigurationCapabilities::PmeDecomposition && pmeRunMode == PmeRunMode::GPU);
+    const bool runConfigurationCouldUsePmeDecompositionOnCpu =
+            (GpuConfigurationCapabilities::Pme && pmeRunMode == PmeRunMode::Mixed);
+    const bool runConfigurationCouldUsePmeDecomposition =
+            (runConfigurationCouldUsePmeDecompositionOnGpu || runConfigurationCouldUsePmeDecompositionOnCpu);
+    const bool pmeGpuDecompositionSupported = canUseGpuAwareMpi && GpuConfigurationCapabilities::PpPmeDirectComm
+                                              && runConfigurationCouldUsePmeDecomposition;
 
     const bool forcePmeGpuDecomposition = std::getenv("GMX_GPU_PME_DECOMPOSITION") != nullptr;