feat: improve accessibility on iOS and Android#587
Merged
Conversation
- Grabber: labeled "Sheet handle" with adjustable role (VoiceOver swipe / TalkBack scroll to resize) - DimView (Android): labeled "Close sheet", hidden from accessibility when invisible - BottomSheetView (Android): pane title announces "Bottom sheet" on appear
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lodev09
changed the title
Mohamed-kassim
added a commit
to Mohamed-kassim/react-native-true-sheet
that referenced
this pull request
Mar 17, 2026
`View.stateDescription` (added in API 30) is called directly in `TrueSheetGrabberView.updateAccessibilityValue()`, causing a fatal `NoSuchMethodError` on Android 10 and below on every sheet present. Replace with `ViewCompat.setStateDescription()` which is a no-op on API < 30 and works identically on API 30+. Introduced in lodev09#587 (v3.10.0-beta.0), still present in beta.2.
lodev09
pushed a commit
that referenced
this pull request
Mar 18, 2026
…606) * fix(android): use ViewCompat.setStateDescription for API < 30 compat `View.stateDescription` (added in API 30) is called directly in `TrueSheetGrabberView.updateAccessibilityValue()`, causing a fatal `NoSuchMethodError` on Android 10 and below on every sheet present. Replace with `ViewCompat.setStateDescription()` which is a no-op on API < 30 and works identically on API 30+. Introduced in #587 (v3.10.0-beta.0), still present in beta.2. * docs: add changelog entry for ViewCompat fix
Owner
Author
|
🚀 This pull request is included in v3.10.0. See Release 3.10.0 for release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UISheetPresentationControllersizingType of Change
Test Plan
Checklist