Commit 0fada5c
authored
feat!(config): support version lists in preprocessing pipeline config for better developer experience (#5083)
resolves #4703
### Config changes (non-breaking)
Support version as list in preprocessing part of config
### Description
Bumping prepro pipeline versions has been a bit of a pain due to having
to copy/paste/delete or comment/uncomment entries - in particular also
when nothing changed but the version (which is the most common case).
This PR makes bumping prepro versions easier by allowing version to be a
list, which acts as syntactic sugar for a copy for each entry in the
list with version substituted by each item's value.
To catch mistakes, we validate that each version appears at most once
and throw an error if that's not the case.
This change is fully backwards compatible. What's *breaking* is that we
can now take advantage of this new feature!
Example usage:
```yaml
preprocessing:
- version: [1, 2, 3] # Creates 3 separate deployments
image: ghcr.io/loculus-project/preprocessing-nextclade
- version: 4 # Creates 1 additional deployment
```
### Screenshot
<img width="1504" height="532" alt="image"
src="https://github.com/user-attachments/assets/6802daab-454c-4076-af90-33488dd72d68"
/>
### Manual testing
I tested that the validation for duplicates works.1 parent 53b2667 commit 0fada5c
File tree
5 files changed
+38
-13
lines changed- kubernetes/loculus
- templates
5 files changed
+38
-13
lines changedLines changed: 18 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
| 11 | + | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
441 | 441 | | |
442 | 442 | | |
443 | 443 | | |
444 | | - | |
445 | | - | |
446 | | - | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
447 | 459 | | |
448 | 460 | | |
449 | 461 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1368 | 1368 | | |
1369 | 1369 | | |
1370 | 1370 | | |
1371 | | - | |
1372 | | - | |
1373 | | - | |
1374 | | - | |
1375 | | - | |
1376 | | - | |
1377 | | - | |
1378 | | - | |
| 1371 | + | |
1379 | 1372 | | |
1380 | 1373 | | |
1381 | 1374 | | |
| |||
0 commit comments