pr feedback - move comments to appropriate locations

Author: EmilioLaiso

lib/API/DX/Device.cpp

@@ -299,8 +299,8 @@ class DXTexture : public offloadtest::Texture {
 public:
   ComPtr<ID3D12Resource> Resource;
   // TODO:
-  // RTV/DSV views own a dedicated single-descriptor heap and are created at
-  // texture creation time. Ideally SRV/UAV views would also live here, but
+  // RTV/DSV own a dedicated single-descriptor heap and are created at
+  // texture creation time. Ideally SRVs/UAVs would also live here, but
   // they currently require a shared CBV_SRV_UAV heap whose indices are
   // determined at pipeline bind time. Moving them here would require a
   // descriptor heap allocator, which is not yet implemented.
@@ -482,9 +482,6 @@ class DXDevice : public offloadtest::Device {
                size_t SizeInBytes) override {
     const D3D12_HEAP_TYPE HeapType = getDXHeapType(Desc.Location);
 
-    // As per the readback heap docs
-    // > Resources in this heap must be created with
-    // > D3D12_RESOURCE_STATE_COPY_DEST, and cannot be changed away from this.
     const D3D12_RESOURCE_FLAGS Flags =
         HeapType == D3D12_HEAP_TYPE_READBACK
             ? D3D12_RESOURCE_FLAG_NONE
@@ -498,6 +495,9 @@ class DXDevice : public offloadtest::Device {
     if (HeapType == D3D12_HEAP_TYPE_UPLOAD)
       InitialState = D3D12_RESOURCE_STATE_GENERIC_READ;
     else if (HeapType == D3D12_HEAP_TYPE_READBACK)
+      // As per the readback heap docs
+      // > Resources in this heap must be created with
+      // > D3D12_RESOURCE_STATE_COPY_DEST, and cannot be changed away from this.
       InitialState = D3D12_RESOURCE_STATE_COPY_DEST;
 
     ComPtr<ID3D12Resource> DeviceBuffer;

lib/API/MTL/MTLResources.h

@@ -21,9 +21,6 @@ namespace offloadtest {
 // Metal requires different storage modes for textures and buffers.
 // Textures use Managed for GpuToCpu because Shared textures are not available
 // on discrete GPUs and lack hardware compression/tiling optimizations.
-// Buffers use Shared for GpuToCpu because they are linear memory with no
-// layout concerns, and Shared avoids the explicit synchronizeResource step
-// that Managed requires.
 inline MTL::StorageMode getMetalTextureStorageMode(MemoryLocation Location) {
   switch (Location) {
   case MemoryLocation::GpuOnly:
@@ -35,6 +32,10 @@ inline MTL::StorageMode getMetalTextureStorageMode(MemoryLocation Location) {
   llvm_unreachable("All MemoryLocation cases handled");
 }
 
+// Metal requires different storage modes for textures and buffers.
+// Buffers use Shared for GpuToCpu because they are linear memory with no
+// layout concerns, and Shared avoids the explicit synchronizeResource step
+// that Managed requires.
 inline MTL::ResourceOptions
 getMetalBufferResourceOptions(MemoryLocation Location) {
   switch (Location) {