[git-llvm-push] Failed to push

[nikic]

Trying to use this tool for the first time, I get:

Checking prerequisites...
Prerequisites met.
On branch: main
Found 1 commit(s) to process.
Processing commit 1667a32: [InstCombine] Use getSigned() for negative number in shift transform
Pushing commit to temporary branch 'users/nikic/instcombine-use-getsigned-for-negative-number-in-shift-transform-1'
Enumerating objects: 2616, done.
Counting objects: 100% (2616/2616), done.
Delta compression using up to 32 threads
Compressing objects: 100% (1025/1025), done.
Writing objects: 100% (1804/1804), 1.83 MiB | 5.30 MiB/s, done.
Total 1804 (delta 1473), reused 1035 (delta 756), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (1473/1473), completed with 685 local objects.
To https://github.com/nikic/llvm-project.git
 ! [remote rejected]           1667a32c4277a8c23a99dc0a7bea8a4413ff2254 -> users/nikic/instcombine-use-getsigned-for-negative-number-in-shift-transform-1 (Unable to determine if workflow can be created or updated due to timeout; `workflows` scope may be required.)
error: failed to push some refs to 'https://github.com/nikic/llvm-project.git'
Error running command: git push https://github.com/nikic/llvm-project.git 1667a32c4277a8c23a99dc0a7bea8a4413ff2254:refs/heads/users/nikic/instcombine-use-getsigned-for-negative-number-in-shift-transform-1
Returning to original branch: main

It seems like the tool is trying to push to the https:// URL for some reason, even though the remote is configured as git@github.com:nikic/llvm-project.git.

cc @ilovepi @boomanaiden154

[llvmbot]

@llvm/issue-subscribers-infrastructure

Author: Nikita Popov (nikic)

Details

Trying to use this tool for the first time, I get: ``` Checking prerequisites... Prerequisites met. On branch: main Found 1 commit(s) to process. Processing commit 1667a32: [InstCombine] Use getSigned() for negative number in shift transform Pushing commit to temporary branch 'users/nikic/instcombine-use-getsigned-for-negative-number-in-shift-transform-1' Enumerating objects: 2616, done. Counting objects: 100% (2616/2616), done. Delta compression using up to 32 threads Compressing objects: 100% (1025/1025), done. Writing objects: 100% (1804/1804), 1.83 MiB | 5.30 MiB/s, done. Total 1804 (delta 1473), reused 1035 (delta 756), pack-reused 0 (from 0) remote: Resolving deltas: 100% (1473/1473), completed with 685 local objects. To https://github.com/nikic/llvm-project.git ! [remote rejected] 1667a32 -> users/nikic/instcombine-use-getsigned-for-negative-number-in-shift-transform-1 (Unable to determine if workflow can be created or updated due to timeout; `workflows` scope may be required.) error: failed to push some refs to 'https://github.com/nikic/llvm-project.git' Error running command: git push https://github.com/nikic/llvm-project.git 1667a32:refs/heads/users/nikic/instcombine-use-getsigned-for-negative-number-in-shift-transform-1 Returning to original branch: main ``` It seems like the tool is trying to push to the `https://` URL for some reason, even though the remote is configured as `git@github.com:nikic/llvm-project.git`.

cc @ilovepi @boomanaiden154

[nikic]

The tool seems to go out of the way to use the HTTPS URL:

llvm-project/llvm/utils/git-llvm-push

Lines 414 to 429 in 1c06165

	def _get_https_url_for_remote(self, remote_name: str) -> str:
	"""Gets the URL for a remote and converts it to HTTPS if necessary."""
	remote_url_result = self.runner.run_command(
	["git", "remote", "get-url", remote_name],
	capture_output=True,
	text=True,
	read_only=True,
	)
	remote_url = remote_url_result.stdout.strip()
	if remote_url.startswith("git@github.com:"):
	return remote_url.replace("git@github.com:", "https://github.com/")
	if remote_url.startswith("https://github.com/"):
	return remote_url
	raise LlvmPrError(
	f"Unsupported remote URL format for {remote_name}: {remote_url}"
	)

Why? Isn't the HTTPS remote usually read-only?

[joker-eph]

Indeed that does not seem right, I would think we could enumerate the configured remotes trying to look for the LLVM one, preferably configured with SSH, and HTTPS otherwise.

[joker-eph]

And there is code to control the remotes already actually:

    parser.add_argument(
        "--remote",
        default=GITHUB_REMOTE_NAME,
        help=f"Remote for your fork to push to (default: {GITHUB_REMOTE_NAME})",
    )
    parser.add_argument(
        "--upstream-remote",
        default=UPSTREAM_REMOTE_NAME,
        help=f"Remote for the upstream repository (default: {UPSTREAM_REMOTE_NAME})",
    )

[nikic]

Yes, I already use --remote fork to specify the correct remote. The problem is that the configured SSH URL is replaced with a HTTPS URL...

I'd expect the tool to directly use the output of git remote get-url --push instead, which will provide the correct URL for pushes.

(Or alternatively not fetch the URL at all? Wouldn't a simple git push [remote] ... instead of git push [remote-url] ... work?)

[joker-eph]

Yes I would expect git push [remote] ... to be the way to push indeed.