Skip to content

Commit 04f4477

Browse files
ci: use diff command for QA URL comments BM-1461 (#1441)
### Motivation When a user modifies tilesets via a pull request, our `build.yml` workflow automatically generates a pull request comment containing QA URLs for the affected tilesets. This allows reviewers to easily examine the imagery. At the moment, our QA URLs are broken for tilesets that describe pipelines. Such as our **`elevation`** tileset. Currently, our `import` command produces the QA URL comments. In this [pull request], we introduce a new `diff` command, which fixes the QA URL issues. [pull request]: linz/basemaps#3555 ### Note We still need the `import` command for handling the DynamoDB operations. We need only switch over to the `diff` command for the QA URL comments. ### Modifications - **.github/workflows/build.yml** - Updated the **`Compare to Production`** step to use the new `diff` CLI command. ### Verification See this comment [here](#1441 (comment)).
1 parent f60a6af commit 04f4477

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
- name: Compare To Production
9090
run: |
9191
aws s3 cp s3://linz-basemaps/config/config-latest.json.gz .
92-
./scripts/bmc.sh ./index.cjs config import --config ${CONFIG_LOCATION_STAGING} --output $PWD/changes.md --target $PWD/config-latest.json.gz
92+
./scripts/bmc.sh ./index.cjs config diff --before $PWD/config-latest.json.gz --after ${CONFIG_LOCATION_STAGING} --output $PWD/changes.md
9393
9494
- name: Upload changes.md as artifact (if oversized)
9595
if: github.ref != 'refs/heads/master' && github.event_name == 'pull_request' && (hashFiles('changes.md') != '')

0 commit comments

Comments
 (0)