Skip to content

Commit d4f8324

Browse files
authored
upcoming: [M3-9517] - Update LKE-E flows to account for LDE being disabled at LA launch (#11880)
* Update copy in node pool panel for LKE-E * Always remove the tooltip for LKE-E * Added changeset: Update LKE-E flows to account for LDE status at LA launch
1 parent 9602ac9 commit d4f8324

File tree

5 files changed

+44
-9
lines changed

5 files changed

+44
-9
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Upcoming Features
3+
---
4+
5+
Update LKE-E flows to account for LDE status at LA launch ([#11880](https://github.com/linode/manager/pull/11880))
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
export const ADD_NODE_POOLS_DESCRIPTION =
22
'Add groups of Linodes to your cluster. You can have a maximum of 100 Linodes per node pool and a maximum of 250 Linodes per cluster.';
33

4+
export const ADD_NODE_POOLS_ENTERPRISE_DESCRIPTION =
5+
'Add groups of Linodes to your cluster. You can have a maximum of 100 Linodes per node pool.';
6+
47
export const ADD_NODE_POOLS_ENCRYPTION_DESCRIPTION =
58
'Node Pool data is encrypted at rest.';
9+
10+
export const ADD_NODE_POOLS_NO_ENCRYPTION_DESCRIPTION =
11+
'Node Pool data is not encrypted at rest for LKE Enterprise clusters.';

packages/manager/src/features/Kubernetes/CreateCluster/NodePoolPanel.tsx

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
1+
import { useRegionsQuery } from '@linode/queries';
12
import { CircleProgress, ErrorState } from '@linode/ui';
23
import Grid from '@mui/material/Grid2';
34
import * as React from 'react';
45

56
import { useIsAcceleratedPlansEnabled } from 'src/features/components/PlansPanel/utils';
6-
import { useRegionsQuery } from '@linode/queries';
77
import { doesRegionSupportFeature } from 'src/utilities/doesRegionSupportFeature';
88
import { extendType } from 'src/utilities/extendType';
99

1010
import {
1111
ADD_NODE_POOLS_DESCRIPTION,
1212
ADD_NODE_POOLS_ENCRYPTION_DESCRIPTION,
13+
ADD_NODE_POOLS_ENTERPRISE_DESCRIPTION,
14+
ADD_NODE_POOLS_NO_ENCRYPTION_DESCRIPTION,
1315
} from '../ClusterList/constants';
1416
import { KubernetesPlansPanel } from '../KubernetesPlansPanel/KubernetesPlansPanel';
1517

@@ -100,15 +102,20 @@ const Panel = (props: NodePoolPanelProps) => {
100102
'Disk Encryption'
101103
);
102104

105+
const getPlansPanelCopy = () => {
106+
// TODO - LKE-E: Remove the 'ADD_NODE_POOLS_NO_ENCRYPTION_DESCRIPTION' copy once LDE is enabled on LKE-E.
107+
if (selectedTier === 'enterprise') {
108+
return `${ADD_NODE_POOLS_ENTERPRISE_DESCRIPTION} ${ADD_NODE_POOLS_NO_ENCRYPTION_DESCRIPTION}`;
109+
}
110+
return regionSupportsDiskEncryption
111+
? `${ADD_NODE_POOLS_DESCRIPTION} ${ADD_NODE_POOLS_ENCRYPTION_DESCRIPTION}`
112+
: ADD_NODE_POOLS_DESCRIPTION;
113+
};
114+
103115
return (
104116
<Grid container direction="column">
105117
<Grid>
106118
<KubernetesPlansPanel
107-
copy={
108-
regionSupportsDiskEncryption
109-
? `${ADD_NODE_POOLS_DESCRIPTION} ${ADD_NODE_POOLS_ENCRYPTION_DESCRIPTION}`
110-
: ADD_NODE_POOLS_DESCRIPTION
111-
}
112119
getTypeCount={(planId) =>
113120
typeCountMap.get(planId) ?? DEFAULT_PLAN_COUNT
114121
}
@@ -121,6 +128,7 @@ const Panel = (props: NodePoolPanelProps) => {
121128
// No Nanodes in Kubernetes clusters
122129
return t.class !== 'nanode';
123130
})}
131+
copy={getPlansPanelCopy()}
124132
error={apiError}
125133
hasSelectedRegion={hasSelectedRegion}
126134
header="Add Node Pools"

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/NodePoolsDisplay/NodeTable.tsx

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { useAllLinodesQuery, useProfile } from '@linode/queries';
12
import { Box, ErrorState, TooltipIcon, Typography } from '@linode/ui';
23
import { DateTime, Interval } from 'luxon';
34
import { enqueueSnackbar } from 'notistack';
@@ -20,7 +21,6 @@ import { TableRow } from 'src/components/TableRow';
2021
import { TableSortCell } from 'src/components/TableSortCell';
2122
import { TagCell } from 'src/components/TagCell/TagCell';
2223
import { useUpdateNodePoolMutation } from 'src/queries/kubernetes';
23-
import { useAllLinodesQuery, useProfile } from '@linode/queries';
2424
import { parseAPIDate } from 'src/utilities/date';
2525
import { getAPIErrorOrDefault } from 'src/utilities/errorUtils';
2626

@@ -270,8 +270,17 @@ export const NodeTable = React.memo((props: Props) => {
270270
</Typography>
271271
<StyledVerticalDivider />
272272
<EncryptedStatus
273+
/**
274+
* M3-9517: Once LDE starts releasing regions with LDE enabled, LDE will still be disabled for the LKE-E LA launch, so hide this tooltip
275+
* explaining how LDE can be enabled on LKE-E node pools.
276+
* TODO - LKE-E: Clean up this enterprise cluster checks once LDE is enabled for LKE-E.
277+
*/
278+
tooltipText={
279+
clusterTier === 'enterprise'
280+
? undefined
281+
: DISK_ENCRYPTION_NODE_POOL_GUIDANCE_COPY
282+
}
273283
encryptionStatus={encryptionStatus}
274-
tooltipText={DISK_ENCRYPTION_NODE_POOL_GUIDANCE_COPY}
275284
/>
276285
</Box>
277286
) : (

packages/manager/src/features/Linodes/LinodeEntityDetailBody.tsx

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,15 @@ export const LinodeEntityDetailBody = React.memo((props: BodyProps) => {
253253
flexDirection="row"
254254
>
255255
<EncryptedStatus
256+
/**
257+
* M3-9517: Once LDE starts releasing regions with LDE enabled, LDE will still be disabled for the LKE-E LA launch, so hide this tooltip
258+
* explaining how LDE can be enabled on LKE-E node pools.
259+
* TODO - LKE-E: Clean up this enterprise cluster checks once LDE is enabled for LKE-E.
260+
*/
256261
tooltipText={
257-
isLKELinode
262+
isLKELinode && cluster?.tier === 'enterprise'
263+
? undefined
264+
: isLKELinode
258265
? UNENCRYPTED_LKE_LINODE_GUIDANCE_COPY
259266
: UNENCRYPTED_STANDARD_LINODE_GUIDANCE_COPY
260267
}

0 commit comments

Comments
 (0)