Skip to content

Commit d423815

Browse files
change: [UIE-9919] - Address post-demo feedback for Network Load Balancers (#13250)
* change: [UIE-9919] - Address post-demo feedback(points 1-3) * Added changeset: NLB post-demo feedback-fix empty state title casing,rename LKE-E to Cluster and adjust column visibility for smaller screens to prioritize IPv6
1 parent b026e5f commit d423815

File tree

6 files changed

+22
-17
lines changed

6 files changed

+22
-17
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@linode/manager": Changed
3+
---
4+
5+
NLB post-demo feedback-fix empty state title casing,rename LKE-E to Cluster and adjust column visibility for smaller screens to prioritize IPv6 ([#13250](https://github.com/linode/manager/pull/13250))

packages/manager/src/features/NetworkLoadBalancers/NetworkLoadBalancersDetail/NetworkLoadBalancerDetailBody.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,11 @@ export const NetworkLoadBalancerDetailBody = (
5959
{regionLabel}
6060
</Box>
6161
<Box>
62-
<StyledTypography>LKE-E Cluster</StyledTypography>
62+
<StyledTypography>Cluster</StyledTypography>
6363
{lkeCluster ? (
6464
<>
6565
<Link
66-
accessibleAriaLabel={`LKE-E Cluster ${lkeCluster.label}`}
66+
accessibleAriaLabel={`Cluster ${lkeCluster.label}`}
6767
className="secondaryLink"
6868
to={`/kubernetes/clusters/${lkeCluster.id}`}
6969
>

packages/manager/src/features/NetworkLoadBalancers/NetworkLoadBalancersDetail/NetworkLoadBalancersDetail.test.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ describe('NetworkLoadBalancersDetail', () => {
9797
expect(getByText('Region')).toBeVisible();
9898
expect(getByText('US, Newark, NJ')).toBeVisible();
9999

100-
expect(getByText('LKE-E Cluster')).toBeVisible();
100+
expect(getByText('Cluster')).toBeVisible();
101101
expect(getByText('None')).toBeVisible();
102102

103103
expect(getByText('Network Load Balancer ID')).toBeVisible();
@@ -121,7 +121,7 @@ describe('NetworkLoadBalancersDetail', () => {
121121

122122
const { getByText } = renderWithTheme(<NetworkLoadBalancersDetail />);
123123

124-
expect(getByText('LKE-E Cluster')).toBeVisible();
124+
expect(getByText('Cluster')).toBeVisible();
125125
expect(getByText(nlbFactory.lke_cluster!.label)).toBeVisible();
126126
expect(
127127
getByText(`(ID: ${nlbFactory.lke_cluster!.id})`, {

packages/manager/src/features/NetworkLoadBalancers/NetworkLoadBalancersLanding/NetworkLoadBalancerTableRow.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -67,18 +67,18 @@ export const NetworkLoadBalancerTableRow = (props: NetworkLoadBalancer) => {
6767
<TableCell data-qa-ports>
6868
<PortsDisplay ports={portStrings} />
6969
</TableCell>
70-
<TableCell data-qa-ipv4>
71-
<IPAddress ips={[address_v4]} isHovered={isHovered} />
72-
</TableCell>
7370
<Hidden mdDown>
74-
<TableCell data-qa-ipv6>
75-
{address_v6 ? (
76-
<IPAddress ips={[address_v6]} isHovered={isHovered} />
77-
) : (
78-
'None'
79-
)}
71+
<TableCell data-qa-ipv4>
72+
<IPAddress ips={[address_v4]} isHovered={isHovered} />
8073
</TableCell>
8174
</Hidden>
75+
<TableCell data-qa-ipv6>
76+
{address_v6 ? (
77+
<IPAddress ips={[address_v6]} isHovered={isHovered} />
78+
) : (
79+
'None'
80+
)}
81+
</TableCell>
8282
<TableCell data-qa-lke-cluster>
8383
{lke_cluster ? (
8484
<Link

packages/manager/src/features/NetworkLoadBalancers/NetworkLoadBalancersLanding/NetworkLoadBalancersLanding.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,11 @@ export const NetworkLoadBalancersLanding = () => {
8484
<TableCell>ID</TableCell>
8585
</Hidden>
8686
<TableCell>Listener Ports</TableCell>
87-
<TableCell>Virtual IP (IPv4)</TableCell>
8887
<Hidden mdDown>
89-
<TableCell>Virtual IP (IPv6)</TableCell>
88+
<TableCell>Virtual IP (IPv4)</TableCell>
9089
</Hidden>
91-
<TableCell>LKE-E Cluster</TableCell>
90+
<TableCell>Virtual IP (IPv6)</TableCell>
91+
<TableCell>Cluster</TableCell>
9292
<Hidden mdDown>
9393
<TableCell>Region</TableCell>
9494
</Hidden>

packages/manager/src/features/NetworkLoadBalancers/NetworkLoadBalancersLanding/NetworkLoadBalancersLandingEmptyState.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export const NetworkLoadBalancersLandingEmptyState = () => {
3030
]}
3131
icon={NetworkIcon}
3232
isEntity
33-
subtitle="High Capacity load balancing service"
33+
subtitle="High capacity network load balancing service"
3434
title="Network Load Balancer"
3535
>
3636
<Typography variant="subtitle1">

0 commit comments

Comments
 (0)