Add python integration test for spontaneous keysend payments#923
Open
heyolaniran wants to merge 2 commits into
Open
Add python integration test for spontaneous keysend payments#923heyolaniran wants to merge 2 commits into
heyolaniran wants to merge 2 commits into
Conversation
this commit adds the test_spontaneous_payment method which : - sets up two nodes in regtest environment, funds them, and opens channel - Arbitrary sends a 2.5M msat keysend with a custom TLV record - Asserts PAYMENT_SUCCESSFUL / PAYMENT_RECEIVED events - verify payment details Shared helpers (_setup_two_nodes, _fund_nodes, _open_channel_and_wait_ready, _stop_and_cleanup) reduce duplication for future integration
|
I've assigned @tnull as a reviewer! |
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
tnull
reviewed
Jun 8, 2026
tnull
left a comment
tnull
left a comment
Collaborator
There was a problem hiding this comment.
CI is currently not available, so we'll need to wait a bit. One comment for now
heyolaniran
force-pushed
the
feat/python_binding_test
branch
from
0a308cb to
8056689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @tnull x @enigbe x @Camillarhi This commit adds the test_spontaneous_payment method which :
Motivation
The python bindings has not coverage for
send_with_custom_tlvsRun the new test