modeMemoryPool_t::reserve bug

[stgeke]

I think https://github.com/libocca/occa/blob/main/src/occa/internal/core/memoryPool.cpp#L131 should be changed to:

} else {
-       resize(reserved + alignedBytes);
+      resize(offset + alignedBytes);
      return slice(reserved, bytes);
}

[stgeke]

I was wrong. Current implementation is correct.

[stgeke]

Actually, there is an issue for the corner case size == reserved + alignedBytes.

[kris-rowe]

@stgeke Is this still an issue?

[stgeke]

Yeah, this needs to be fixed.

[kris-rowe]

In the occa that comes with nekRS, this was changed as suggested above (to resize(offset + alignedBytes);), but later reverted.
Is it safe to assume the existing implementation in OCCA is correct?

[stgeke]

I suggest to diff the changes carefully but if I recall correctly this line
https://github.com/libocca/occa/blob/main/src/occa/internal/core/memoryPool.cpp#L143
has to be removed.