fix review comments, add update feature, and add tests

Author: oddish3

src/apyanki/note.py

@@ -632,6 +632,7 @@ def update_or_add_to_collection(self, anki: Anki) -> Note:
             try:
                 # Import NoteId here to avoid circular imports at module level
                 from anki.notes import NoteId
+
                 note_id = NoteId(int(self.nid))
                 existing_note = anki.col.get_note(note_id)
                 return self._update_note(anki, existing_note)
@@ -649,6 +650,7 @@ def update_or_add_to_collection(self, anki: Anki) -> Note:
             try:
                 # Import CardId here to avoid circular imports at module level
                 from anki.cards import CardId
+
                 card_id = CardId(int(self.cid))
                 card = anki.col.get_card(card_id)
                 if card:
@@ -666,7 +668,7 @@ def update_or_add_to_collection(self, anki: Anki) -> Note:
         # If no existing note found or ID not provided, add as new
         return self.add_to_collection(anki)
 
-    def _update_note(self, anki: 'Anki', existing_note: Any) -> Note:
+    def _update_note(self, anki: "Anki", existing_note: Any) -> Note:
         """Update an existing note with new field values
 
         Returns: The updated note

tests/test_batch_edit.py

@@ -58,7 +58,9 @@ def test_update_from_file(collection):
     """Test updating a note from a Markdown file."""
     # First create a note
     with open("test.md", "w") as f:
-        f.write(textwrap.dedent("""\
+        f.write(
+            textwrap.dedent(
+                """\
             model: Basic
             tags: marked
 
@@ -68,7 +70,9 @@ def test_update_from_file(collection):
 
             ## Back
             Original answer.
-            """))
+            """
+            )
+        )
 
     with Anki(collection_db_path=collection) as a:
         # Add initial note
@@ -77,7 +81,9 @@ def test_update_from_file(collection):
 
         # Now create update file with the note ID
         with open("test_update.md", "w") as f:
-            f.write(textwrap.dedent(f"""\
+            f.write(
+                textwrap.dedent(
+                    f"""\
                 model: Basic
                 tags: marked updated
                 nid: {note_id}
@@ -88,7 +94,9 @@ def test_update_from_file(collection):
 
                 ## Back
                 Updated answer.
-                """))
+                """
+                )
+            )
 
         # Update the note
         updated_note = a.update_notes_from_file("test_update.md")[0]
@@ -109,7 +117,9 @@ def test_update_from_file_by_cid(collection):
     """Test updating a note from a Markdown file using card ID."""
     # First create a note
     with open("test.md", "w") as f:
-        f.write(textwrap.dedent("""\
+        f.write(
+            textwrap.dedent(
+                """\
             model: Basic
             tags: marked
 
@@ -119,7 +129,9 @@ def test_update_from_file_by_cid(collection):
 
             ## Back
             Original answer.
-            """))
+            """
+            )
+        )
 
     with Anki(collection_db_path=collection) as a:
         # Add initial note
@@ -128,7 +140,9 @@ def test_update_from_file_by_cid(collection):
 
         # Now create update file with the card ID
         with open("test_update_cid.md", "w") as f:
-            f.write(textwrap.dedent(f"""\
+            f.write(
+                textwrap.dedent(
+                    f"""\
                 model: Basic
                 tags: marked card-updated
                 cid: {card_id}
@@ -139,7 +153,9 @@ def test_update_from_file_by_cid(collection):
 
                 ## Back
                 Updated answer via card ID.
-                """))
+                """
+                )
+            )
 
         # Update the note
         updated_note = a.update_notes_from_file("test_update_cid.md")[0]
@@ -159,7 +175,9 @@ def test_update_from_file_new_and_existing(collection):
     """Test updating a file with both new and existing notes."""
     # First create a note
     with open("test.md", "w") as f:
-        f.write(textwrap.dedent("""\
+        f.write(
+            textwrap.dedent(
+                """\
             model: Basic
             tags: marked
 
@@ -169,7 +187,9 @@ def test_update_from_file_new_and_existing(collection):
 
             ## Back
             Original answer.
-            """))
+            """
+            )
+        )
 
     with Anki(collection_db_path=collection) as a:
         # Add initial note
@@ -178,7 +198,9 @@ def test_update_from_file_new_and_existing(collection):
 
         # Now create update file with both the existing note and a new note
         with open("test_mixed.md", "w") as f:
-            f.write(textwrap.dedent(f"""\
+            f.write(
+                textwrap.dedent(
+                    f"""\
                 model: Basic
                 tags: common-tag
 
@@ -200,7 +222,9 @@ def test_update_from_file_new_and_existing(collection):
 
                 ## Back
                 Brand new content.
-                """))
+                """
+                )
+            )
 
         # Update the note
         updated_notes = a.update_notes_from_file("test_mixed.md")
@@ -233,7 +257,9 @@ def test_update_file_with_note_ids(collection):
     """Test that --update-file option updates the original file with note IDs."""
     # First create a note file without IDs
     with open("test_no_ids.md", "w") as f:
-        f.write(textwrap.dedent("""\
+        f.write(
+            textwrap.dedent(
+                """\
             model: Basic
             tags: test-update-file
 
@@ -250,23 +276,25 @@ def test_update_file_with_note_ids(collection):
 
             ## Back
             Another test answer
-            """))
+            """
+            )
+        )
 
     with Anki(collection_db_path=collection) as a:
         # Add notes with update_file=True
         notes = a.add_notes_from_file("test_no_ids.md", update_file=True)
-        
+
         # Verify two notes were added
         assert len(notes) == 2
-        
+
         # Read the file again to check if IDs were added
         with open("test_no_ids.md", "r") as f:
             updated_content = f.read()
-        
+
         # The file should now contain nid: lines
         assert f"nid: {notes[0].n.id}" in updated_content
         assert f"nid: {notes[1].n.id}" in updated_content
-        
+
     # Clean up
     os.remove("test_no_ids.md")
 
@@ -275,7 +303,9 @@ def test_update_file_with_mixed_notes(collection):
     """Test that --update-file option updates only new notes in update-from-file."""
     # First create a note to get its ID
     with open("test_initial.md", "w") as f:
-        f.write(textwrap.dedent("""\
+        f.write(
+            textwrap.dedent(
+                """\
             model: Basic
             tags: initial-note
 
@@ -285,16 +315,20 @@ def test_update_file_with_mixed_notes(collection):
 
             ## Back
             Initial answer
-            """))
+            """
+            )
+        )
 
     with Anki(collection_db_path=collection) as a:
         # Add the initial note
         initial_note = a.add_notes_from_file("test_initial.md")[0]
         note_id = initial_note.n.id
-        
+
         # Now create a file with the existing note ID and a new note
         with open("test_update_mix.md", "w") as f:
-            f.write(textwrap.dedent(f"""\
+            f.write(
+                textwrap.dedent(
+                    f"""\
                 model: Basic
                 tags: common-tag
 
@@ -316,23 +350,25 @@ def test_update_file_with_mixed_notes(collection):
 
                 ## Back
                 New answer without ID
-                """))
-        
+                """
+                )
+            )
+
         # Update notes with update_file=True
         notes = a.update_notes_from_file("test_update_mix.md", update_file=True)
-        
+
         # Verify two notes were affected
         assert len(notes) == 2
-        
+
         # Read the updated file
         with open("test_update_mix.md", "r") as f:
             updated_content = f.read()
-        
+
         # Verify the original ID is preserved and the new note got an ID
         new_note = next(n for n in notes if n.n.id != note_id)
         assert f"nid: {note_id}" in updated_content  # Original ID
         assert f"nid: {new_note.n.id}" in updated_content  # New ID
-        
+
     # Clean up
     os.remove("test_initial.md")
     os.remove("test_update_mix.md")