Skip to content

Commit ded99c2

Browse files
efahlrobimarko
authored andcommitted
treewide: add explicit default variant part 2
Add 'DEFAULT_VARIANT' to two packages, 'iw' and 'eapol-test', that were missed in the first pass. Refactor 'iw' and 'ethtool' package definitions to be consistent with the pattern used in most other packages. Fixes: openwrt/openwrt@f4fdb996 Fixes: openwrt/openwrt@7a78dc4a Signed-off-by: Eric Fahlgren <ericfahlgren@gmail.com> Link: openwrt/openwrt#21380 Signed-off-by: Robert Marko <robimarko@gmail.com>
1 parent a10d10e commit ded99c2

File tree

3 files changed

+14
-7
lines changed

3 files changed

+14
-7
lines changed

package/network/services/hostapd/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -544,6 +544,7 @@ define Package/eapol-test
544544
$(call Package/eapol-test/Default,$(1))
545545
TITLE+= (built-in full)
546546
VARIANT:=supplicant-full-internal
547+
DEFAULT_VARIANT:=1
547548
endef
548549

549550
define Package/eapol-test-openssl

package/network/utils/ethtool/Makefile

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,24 +26,25 @@ PKG_BUILD_PARALLEL:=1
2626

2727
include $(INCLUDE_DIR)/package.mk
2828

29-
define Package/ethtool
29+
define Package/ethtool/Default
3030
SECTION:=net
3131
CATEGORY:=Network
3232
TITLE:=Display or change ethernet card settings
3333
URL:=https://www.kernel.org/pub/software/network/ethtool/
34+
endef
35+
36+
define Package/ethtool
37+
$(call Package/ethtool/Default)
3438
VARIANT:=tiny
35-
CONFLICTS:=ethtool-full
3639
DEFAULT_VARIANT:=1
3740
endef
3841

3942
define Package/ethtool-full
40-
$(Package/ethtool)
43+
$(call Package/ethtool/Default)
4144
TITLE += (full)
4245
VARIANT:=full
4346
PROVIDES:=ethtool
4447
DEPENDS:=+libmnl
45-
CONFLICTS:=
46-
DEFAULT_VARIANT:=
4748
endef
4849

4950
define Package/ethtool/description

package/network/utils/iw/Makefile

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,22 @@ PKG_BUILD_FLAGS:=gc-sections lto
2323

2424
include $(INCLUDE_DIR)/package.mk
2525

26-
define Package/iw
26+
define Package/iw/Default
2727
SECTION:=net
2828
CATEGORY:=Network
2929
TITLE:=cfg80211 interface configuration utility
3030
URL:=https://wireless.kernel.org/en/latest/en/users/documentation/iw.html
3131
DEPENDS:= +libnl-tiny
32+
endef
33+
34+
define Package/iw
35+
$(call Package/iw/Default)
3236
VARIANT:=tiny
37+
DEFAULT_VARIANT:=1
3338
endef
3439

3540
define Package/iw-full
36-
$(Package/iw)
41+
$(call Package/iw/Default)
3742
TITLE += (full version)
3843
VARIANT:=full
3944
PROVIDES:=iw

0 commit comments

Comments
 (0)