-
Notifications
You must be signed in to change notification settings - Fork 933
Description
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Observed behavior
1. Submit attendance
If I go to mark the attendance and I simply click the enabled Submit attendance button then I don't see a modal asking me to confirm the submission. (while I would expect one just to make sure)
At the same time if I simply toggle the Mark all learners present switch then I see a confirmation modal 'Mark all N learners as present?
This will override N learners currently marked absent.' - this is unexpected - I would expect such a modal to appear only if I have a mixture of present and absent learners and not at the default state.
Lastly when I have a mixed selection of present and absent learners and I click the Submit attendance button I'm also not prompted to confirm...
2. Closing the Mark attendance page
When I attempt to close the Mark attendance page I see an 'Unsaved changes You have unsaved changes. Are you sure you want to leave? STAY LEAVE' modal. It would be much better if we could make it consistent with similar modals that we have. (There's really no way to save my changes, and STAY and LEAVE are a bit too strong)
3. Edit attendance
Here the Save N changes modal can be confusing especially after toggling the 'Mark all learners present' switch:
Save.N.changes.mp4
Would recommend not calculating the N number of changes in the title of the modal, the number of present vs absent should be sufficient and clear enough.
Expected behavior
To be further discussed.
Steps to reproduce the issue
- Install the build from https://github.com/learningequality/kolibri/releases/tag/v0.19.3-rc1
- Go to
Coach > Class home > class > Mark attendance
Usage Details
Windows 11, Ubuntu 22, Mac OS 15.5 - Chrome, Firefox
https://github.com/learningequality/kolibri/releases/tag/v0.19.3-rc1
