Skip to content

[HTML5 Article Renderer] Refactor the use of the styling prop override #13852

@akolson

Description

@akolson

This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Current behavior

Currently, the SafeHTML.vue
file includes a styleOverrides prop that allows styles to be passed down to its child components. However, this appears to be redundant, as the styling can be defined and managed directly within the child components themselves.

Desired behavior

Remove the styleOverrides prop from the SafeHTML component and apply the necessary styling directly within the affected child components. This change may also be related to this issue.

Update:
With the styleOverrides prop removed removed from the SafeHTML/index.js file in this pr, there remain usage residues that should also be removed from the following files;

  • packages/kolibri-common/components/SafeHTML/Lightbox.vue
  • packages/kolibri-common/components/SafeHTML/SafeHtmlImage.vue

Value add

Clearer styling

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions