chore: Update to net8 for server sdks (#102)

jsonbailey · web-flow · commit ddae814250cb · 2025-05-16T11:29:26.000-05:00
diff --git a/.github/actions/build-docs/action.yml b/.github/actions/build-docs/action.yml
@@ -11,7 +11,7 @@ runs:
     - name: Setup dotnet build tools
       uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: 6.0
+        dotnet-version: 8.0
     - name: Install docfx
       shell: bash
       run:  dotnet tool update -g docfx
diff --git a/.github/actions/ci/action.yml b/.github/actions/ci/action.yml
@@ -10,7 +10,7 @@ inputs:
   target_test_framework:
     description: 'The target test framework to use.'
     required: false
-    default: 'net6.0'
+    default: 'net8.0'
   test_verbosity:
     description: 'The verbosity level of the test output.'
     required: false
@@ -23,8 +23,8 @@ runs:
       uses: actions/setup-dotnet@v4
       with:
         dotnet-version: |
-              6.0
-              7.0
+          8.0
+          7.0
 
     - name: Copy global.json in place
       shell: bash
diff --git a/.github/actions/contract-tests/action.yml b/.github/actions/contract-tests/action.yml
@@ -18,7 +18,7 @@ runs:
     - name: Setup dotnet build tools
       uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: 6.0
+        dotnet-version: 8.0
 
     - name: Restore Workloads
       shell: bash
diff --git a/.github/workflows/sdk-client-ci.yml b/.github/workflows/sdk-client-ci.yml
@@ -20,6 +20,9 @@ jobs:
       id-token: write
       contents: read
     steps:
+      - name: Print Xcode Version
+        run: xcodebuild -version
+
       - uses: actions/checkout@v4
 
       - name: Setup Env from project's Env file
diff --git a/global.example.json b/global.example.json
@@ -1,6 +1,6 @@
 {
   "sdk": {
-    "version": "7.0.410",
+    "version": "8.0.0",
     "rollForward": "latestFeature"
   }
 }
diff --git a/pkgs/sdk/client/contract-tests/README.md b/pkgs/sdk/client/contract-tests/README.md
@@ -6,4 +6,4 @@ To run these tests locally, run `make contract-tests` from the SDK project root
 
 Or, to test against an in-progress local version of the test harness, run `make start-contract-test-service` from the SDK project root directory; then, in the root directory of the `sdk-test-harness` project, build the test harness and run it from the command line.
 
-Currently, the project does _not_ automatically detect the available target frameworks. It will default to building and running for .NET Core 2.1. To use a different target framework, set the environment variable `TESTFRAMEWORK` to the name of the application runtime framework (such as `netcoreapp3.1`), and set the environment variable `BUILDFRAMEWORKS` (note the S at the end) to the target framework that the SDK should be built for (which may or may not be the same).
+Currently, the project does _not_ automatically detect the available target frameworks. It will default to building and running for .NET 7.0. To use a different target framework, set the environment variable `TESTFRAMEWORK` to the name of the application runtime framework (such as `net7.0`), and set the environment variable `BUILDFRAMEWORKS` (note the S at the end) to the target framework that the SDK should be built for (which may or may not be the same).
diff --git a/pkgs/sdk/server-ai/README.md b/pkgs/sdk/server-ai/README.md
@@ -22,7 +22,7 @@ Currently there is no client-side AI SDK for .NET. If you're interested, please
 
 This version of the AI SDK is built for the following targets:
 
-* .NET 7.0: runs on .NET 7.0 and above (including higher major versions).
+* .NET 8.0: runs on .NET 8.0 and above (including higher major versions).
 * .NET Framework 4.6.2: runs on .NET Framework 4.6.2 and above.
 * .NET Standard 2.0: runs in any project that is targeted to .NET Standard 2.x rather than to a specific runtime platform.
 
diff --git a/pkgs/sdk/server-ai/src/LaunchDarkly.ServerSdk.Ai.csproj b/pkgs/sdk/server-ai/src/LaunchDarkly.ServerSdk.Ai.csproj
@@ -7,7 +7,7 @@
          single framework that we are testing; this allows us to test with older SDK
          versions that would error out if they saw any newer target frameworks listed
          here, even if we weren't running those. -->
-    <BuildFrameworks Condition="'$(BUILDFRAMEWORKS)' == ''">netstandard2.0;net462;net6.0</BuildFrameworks>
+    <BuildFrameworks Condition="'$(BUILDFRAMEWORKS)' == ''">netstandard2.0;net462;net8.0</BuildFrameworks>
     <TargetFrameworks>$(BUILDFRAMEWORKS)</TargetFrameworks>
     <!-- Note: whenever we add or remove supported target frameworks, we must update ServerDiagnosticStore.GetDotNetTargetFramework() -->
     <DebugType>portable</DebugType>
diff --git a/pkgs/sdk/server-ai/test/LaunchDarkly.ServerSdk.Ai.Tests.csproj b/pkgs/sdk/server-ai/test/LaunchDarkly.ServerSdk.Ai.Tests.csproj
@@ -4,7 +4,7 @@
          single framework that we are testing; this allows us to test with older SDK
          versions that would error out if they saw any newer target frameworks listed
          here, even if we weren't running those. -->
-    <TestFramework Condition="'$(TESTFRAMEWORK)' == ''">net462;net6.0</TestFramework>
+    <TestFramework Condition="'$(TESTFRAMEWORK)' == ''">net462;net8.0</TestFramework>
     <TargetFrameworks>$(TESTFRAMEWORK)</TargetFrameworks>
     <AssemblyName>LaunchDarkly.ServerSdk.Ai.Tests</AssemblyName>
     <PackageId>LaunchDarkly.ServerSdk.Ai.Tests</PackageId>
diff --git a/pkgs/sdk/server/Makefile b/pkgs/sdk/server/Makefile
@@ -9,8 +9,8 @@ clean:
 	dotnet clean
 
 TEMP_TEST_OUTPUT=/tmp/sdk-contract-test-service.log
-BUILDFRAMEWORKS ?= net6.0
-TESTFRAMEWORK ?= net6.0
+BUILDFRAMEWORKS ?= net8.0
+TESTFRAMEWORK ?= net8.0
 
 build-contract-tests:
 	@cd contract-tests && dotnet build TestService.csproj
diff --git a/pkgs/sdk/server/README.md b/pkgs/sdk/server/README.md
@@ -14,16 +14,16 @@ For using LaunchDarkly in *client-side* .NET applications, including mobile (MAU
 
 This version of the SDK is built for the following targets:
 
-* .NET 6.0: runs on .NET 6.0 and above (including higher major versions).
+* .NET 8.0: runs on .NET 8.0 and above (including higher major versions).
 * .NET Framework 4.6.2: runs on .NET Framework 4.6.2 and above.
 * .NET Standard 2.0: runs in any project that is targeted to .NET Standard 2.x rather than to a specific runtime platform.
 
 The .NET build tools should automatically load the most appropriate build of the SDK for whatever platform your application or library is targeted to.
 
 The only differences in the SDK between platforms are these:
 
-* Setting a TCP connection timeout is only supported in .NET Core and .NET 6.0+. For more details, see `HttpConfigurationBuilder.ConnectTimeout`.
-* The SDK requires the `System.Text.Json` API to be available; it is built into the standard runtime library in .NET Core and .NET 6.0+, but not on other platforms, so on other platforms the SDK brings in `System.Text.Json` as a NuGet package dependency.
+* Setting a TCP connection timeout is only supported in .NET Core and .NET 8.0+. For more details, see `HttpConfigurationBuilder.ConnectTimeout`.
+* The SDK requires the `System.Text.Json` API to be available; it is built into the standard runtime library in .NET Core and .NET 8.0+, but not on other platforms, so on other platforms the SDK brings in `System.Text.Json` as a NuGet package dependency.
 
 ## Getting started
 
diff --git a/pkgs/sdk/server/contract-tests/README.md b/pkgs/sdk/server/contract-tests/README.md
@@ -6,4 +6,4 @@ To run these tests locally, run `make contract-tests` from the SDK project root
 
 Or, to test against an in-progress local version of the test harness, run `make start-contract-test-service` from the SDK project root directory; then, in the root directory of the `sdk-test-harness` project, build the test harness and run it from the command line.
 
-Currently, the project does _not_ automatically detect the available target frameworks. It will default to building and running for .NET Core 3.1. To use a different target framework, set the environment variable `TESTFRAMEWORK` to the name of the application runtime framework (such as `netcoreapp3.1`), and set the environment variable `BUILDFRAMEWORKS` (note the S at the end) to the target framework that the SDK should be built for (which may or may not be the same).
+Currently, the project does _not_ automatically detect the available target frameworks. It will default to building and running for .NET 8.0. To use a different target framework, set the environment variable `TESTFRAMEWORK` to the name of the application runtime framework (such as `net8.0`), and set the environment variable `BUILDFRAMEWORKS` (note the S at the end) to the target framework that the SDK should be built for (which may or may not be the same).
diff --git a/pkgs/sdk/server/contract-tests/TestService.csproj b/pkgs/sdk/server/contract-tests/TestService.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TestFramework Condition="'$(TESTFRAMEWORK)' == ''">net6.0</TestFramework>
+    <TestFramework Condition="'$(TESTFRAMEWORK)' == ''">net8.0</TestFramework>
     <TargetFrameworks>$(TESTFRAMEWORK)</TargetFrameworks>
     <DebugType>portable</DebugType>
     <AssemblyName>ContractTestService</AssemblyName>
diff --git a/pkgs/sdk/server/github_actions.env b/pkgs/sdk/server/github_actions.env
@@ -4,4 +4,4 @@ BUILD_OUTPUT_PATH=pkgs/sdk/server/src/bin/Release/
 BUILD_OUTPUT_DLL_NAME=LaunchDarkly.ServerSdk.dll
 TEST_PROJECT_FILE=pkgs/sdk/server/test/LaunchDarkly.ServerSdk.Tests.csproj
 CONTRACT_TEST_PROJECT_FILE=pkgs/sdk/server/contract-tests/TestService.csproj
-CONTRACT_TEST_DLL_FILE=pkgs/sdk/server/contract-tests/bin/debug/net6.0/ContractTestService.dll
+CONTRACT_TEST_DLL_FILE=pkgs/sdk/server/contract-tests/bin/debug/net8.0/ContractTestService.dll
diff --git a/pkgs/sdk/server/src/Internal/Events/ServerDiagnosticStore.cs b/pkgs/sdk/server/src/Internal/Events/ServerDiagnosticStore.cs
@@ -69,8 +69,8 @@ internal static string GetDotNetTargetFramework()
             return "netstandard2.0";
 #elif NET462
             return "net462";
-#elif NET6_0
-            return "net6.0";
+#elif NET8_0
+            return "net8.0";
 #else
             return "unknown";
 #endif
diff --git a/pkgs/sdk/server/src/LaunchDarkly.ServerSdk.csproj b/pkgs/sdk/server/src/LaunchDarkly.ServerSdk.csproj
@@ -7,7 +7,7 @@
          single framework that we are testing; this allows us to test with older SDK
          versions that would error out if they saw any newer target frameworks listed
          here, even if we weren't running those. -->
-    <BuildFrameworks Condition="'$(BUILDFRAMEWORKS)' == ''">netstandard2.0;net462;net6.0</BuildFrameworks>
+    <BuildFrameworks Condition="'$(BUILDFRAMEWORKS)' == ''">netstandard2.0;net462;net8.0</BuildFrameworks>
     <TargetFrameworks>$(BUILDFRAMEWORKS)</TargetFrameworks>
     <!-- Note: whenever we add or remove supported target frameworks, we must update ServerDiagnosticStore.GetDotNetTargetFramework() -->
     <DebugType>portable</DebugType>
@@ -48,7 +48,7 @@
 
   <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'net462'">
     <PackageReference Include="System.Text.Json" Version="6.0.10" />
-    <!-- it's a built-in package in net6.0 -->
+    <!-- it's a built-in package in net8.0 -->
   </ItemGroup>
 
 
diff --git a/pkgs/sdk/server/test/LaunchDarkly.ServerSdk.Tests.csproj b/pkgs/sdk/server/test/LaunchDarkly.ServerSdk.Tests.csproj
@@ -4,7 +4,7 @@
          single framework that we are testing; this allows us to test with older SDK
          versions that would error out if they saw any newer target frameworks listed
          here, even if we weren't running those. -->
-    <TestFramework Condition="'$(TESTFRAMEWORK)' == ''">net462;net6.0</TestFramework>
+    <TestFramework Condition="'$(TESTFRAMEWORK)' == ''">net462;net8.0</TestFramework>
     <TargetFrameworks>$(TESTFRAMEWORK)</TargetFrameworks>
     <AssemblyName>LaunchDarkly.ServerSdk.Tests</AssemblyName>
     <PackageId>LaunchDarkly.ServerSdk.Tests</PackageId>
diff --git a/pkgs/telemetry/src/LaunchDarkly.ServerSdk.Telemetry.csproj b/pkgs/telemetry/src/LaunchDarkly.ServerSdk.Telemetry.csproj
@@ -7,7 +7,7 @@
          single framework that we are testing; this allows us to test with older SDK
          versions that would error out if they saw any newer target frameworks listed
          here, even if we weren't running those. -->
-    <BuildFrameworks Condition="'$(BUILDFRAMEWORKS)' == ''">netstandard2.0;net462;net6.0</BuildFrameworks>
+    <BuildFrameworks Condition="'$(BUILDFRAMEWORKS)' == ''">netstandard2.0;net462;net8.0</BuildFrameworks>
     <TargetFrameworks>$(BUILDFRAMEWORKS)</TargetFrameworks>
     <DebugType>portable</DebugType>
     <AssemblyName>LaunchDarkly.ServerSdk.Telemetry</AssemblyName>
@@ -41,7 +41,7 @@
   </ItemGroup>
 
   <ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0' or '$(TargetFramework)' == 'net462'">
-    <!-- Use any 5.x to 8.x.  It's a built-in package in net6.0, hence conditional for targets -->
+    <!-- Use any 5.x to 8.x.  It's a built-in package in net8.0, hence conditional for targets -->
     <PackageReference Include="System.Diagnostics.DiagnosticSource" Version="[5,9)" />
   </ItemGroup>
 
diff --git a/pkgs/telemetry/test/LaunchDarkly.ServerSdk.Telemetry.Tests.csproj b/pkgs/telemetry/test/LaunchDarkly.ServerSdk.Telemetry.Tests.csproj
@@ -4,7 +4,7 @@
          single framework that we are testing; this allows us to test with older SDK
          versions that would error out if they saw any newer target frameworks listed
          here, even if we weren't running those. -->
-    <TestFramework Condition="'$(TESTFRAMEWORK)' == ''">net462;net6.0</TestFramework>
+    <TestFramework Condition="'$(TESTFRAMEWORK)' == ''">net462;net8.0</TestFramework>
     <TargetFrameworks>$(TESTFRAMEWORK)</TargetFrameworks>
     <AssemblyName>LaunchDarkly.ServerSdk.Telemetry.Tests</AssemblyName>
     <PackageId>LaunchDarkly.ServerSdk.Telemetry.Tests</PackageId>

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"sdk": {`
`3`		`- "version": "7.0.410",`
	`3`	`+ "version": "8.0.0",`
`4`	`4`	`"rollForward": "latestFeature"`
`5`	`5`	`}`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
@@ -6,4 +6,4 @@ To run these tests locally, run `make contract-tests` from the SDK project root
`6`	`6`
`7`	`7`	Or, to test against an in-progress local version of the test harness, run `make start-contract-test-service` from the SDK project root directory; then, in the root directory of the `sdk-test-harness` project, build the test harness and run it from the command line.
`8`	`8`
`9`		-Currently, the project does _not_ automatically detect the available target frameworks. It will default to building and running for .NET Core 2.1. To use a different target framework, set the environment variable `TESTFRAMEWORK` to the name of the application runtime framework (such as `netcoreapp3.1`), and set the environment variable `BUILDFRAMEWORKS` (note the S at the end) to the target framework that the SDK should be built for (which may or may not be the same).
	`9`	+Currently, the project does _not_ automatically detect the available target frameworks. It will default to building and running for .NET 7.0. To use a different target framework, set the environment variable `TESTFRAMEWORK` to the name of the application runtime framework (such as `net7.0`), and set the environment variable `BUILDFRAMEWORKS` (note the S at the end) to the target framework that the SDK should be built for (which may or may not be the same).