Skip to content

Commit 2783ae1

Browse files
committed
ci: fix MySQL and MariaDB wait commands in SQLx workflows
1 parent 2728d2b commit 2783ae1

File tree

1 file changed

+33
-5
lines changed

1 file changed

+33
-5
lines changed

.github/workflows/sqlx.yml

Lines changed: 33 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,13 @@ jobs:
446446

447447
- run: docker compose -f tests/docker-compose.yml run -d -p 3306:3306 --name mysql_${{ matrix.mysql }} mysql_${{ matrix.mysql }}
448448
- name: Wait for MySQL
449-
run: timeout 60s bash -c 'until docker exec mysql_${{ matrix.mysql }} mysqladmin ping -uroot -ppassword --silent; do sleep 1; done' || (docker logs mysql_${{ matrix.mysql }} && exit 1)
449+
run: |
450+
docker exec mysql_${{ matrix.mysql }} bash -c '
451+
until (command -v mysqladmin >/dev/null && mysqladmin ping -uroot -ppassword --silent) || \
452+
(command -v mariadb-admin >/dev/null && mariadb-admin ping -uroot -ppassword --silent); do
453+
sleep 2
454+
done
455+
'
450456
451457
# Create data dir for offline mode
452458
- run: mkdir .sqlx
@@ -538,7 +544,12 @@ jobs:
538544
run: |
539545
docker stop mysql_${{ matrix.mysql }}
540546
docker compose -f tests/docker-compose.yml run -d -p 3306:3306 --name mysql_${{ matrix.mysql }}_client_ssl mysql_${{ matrix.mysql }}_client_ssl
541-
timeout 60s bash -c 'until docker exec mysql_${{ matrix.mysql }}_client_ssl mysqladmin ping -uroot --silent; do sleep 1; done' || (docker logs mysql_${{ matrix.mysql }}_client_ssl && exit 1)
547+
docker exec mysql_${{ matrix.mysql }}_client_ssl bash -c '
548+
until (command -v mysqladmin >/dev/null && mysqladmin ping -uroot --silent) || \
549+
(command -v mariadb-admin >/dev/null && mariadb-admin ping -uroot --silent); do
550+
sleep 2
551+
done
552+
'
542553
543554
- if: ${{ matrix.tls != 'none' }}
544555
run: |
@@ -570,7 +581,13 @@ jobs:
570581

571582
- run: docker compose -f tests/docker-compose.yml run -d -p 3306:3306 --name mysql_8 mysql_8
572583
- name: Wait for MySQL
573-
run: timeout 60s bash -c 'until docker exec mysql_8 mysqladmin ping -uroot -ppassword --silent; do sleep 1; done' || (docker logs mysql_8 && exit 1)
584+
run: |
585+
docker exec mysql_8 bash -c '
586+
until (command -v mysqladmin >/dev/null && mysqladmin ping -uroot -ppassword --silent) || \
587+
(command -v mariadb-admin >/dev/null && mariadb-admin ping -uroot -ppassword --silent); do
588+
sleep 2
589+
done
590+
'
574591
575592
# Run isolated MySQL tests to avoid stalling the main job.
576593
- run: |
@@ -609,7 +626,13 @@ jobs:
609626

610627
- run: docker compose -f tests/docker-compose.yml run -d -p 3306:3306 --name mariadb_${{ matrix.mariadb }} mariadb_${{ matrix.mariadb }}
611628
- name: Wait for MariaDB
612-
run: timeout 60s bash -c 'until docker exec mariadb_${{ matrix.mariadb }} mysqladmin ping -uroot -ppassword --silent; do sleep 1; done' || (docker logs mariadb_${{ matrix.mariadb }} && exit 1)
629+
run: |
630+
docker exec mariadb_${{ matrix.mariadb }} bash -c '
631+
until (command -v mysqladmin >/dev/null && mysqladmin ping -uroot -ppassword --silent) || \
632+
(command -v mariadb-admin >/dev/null && mariadb-admin ping -uroot -ppassword --silent); do
633+
sleep 2
634+
done
635+
'
613636
614637
# Create data dir for offline mode
615638
- run: mkdir .sqlx
@@ -672,7 +695,12 @@ jobs:
672695
run: |
673696
docker stop mariadb_${{ matrix.mariadb }}
674697
docker compose -f tests/docker-compose.yml run -d -p 3306:3306 --name mariadb_${{ matrix.mariadb }}_client_ssl mariadb_${{ matrix.mariadb }}_client_ssl
675-
timeout 60s bash -c 'until docker exec mariadb_${{ matrix.mariadb }}_client_ssl mysqladmin ping -uroot --silent; do sleep 1; done' || (docker logs mariadb_${{ matrix.mariadb }}_client_ssl && exit 1)
698+
docker exec mariadb_${{ matrix.mariadb }}_client_ssl bash -c '
699+
until (command -v mysqladmin >/dev/null && mysqladmin ping -uroot --silent) || \
700+
(command -v mariadb-admin >/dev/null && mariadb-admin ping -uroot --silent); do
701+
sleep 2
702+
done
703+
'
676704
677705
- if: ${{ matrix.tls != 'none' }}
678706
run: |

0 commit comments

Comments
 (0)