testing.TB should not be require name to be `tb`, prefer `t`

[prashantv]

It's more common to name thetesting.TB parameter t instead of tb as required by the tb_name linter.

data from github,
t testing.TB has ~64k hits
tb testing.TB has ~10k hits

Even within the Go repo, t testing.TB is more common (~10 hits) than tb testing.TB (<5 hits)

[kulti]

Good point! As well it will be a breaking change.

I think it's a good idea to have the same name for the similar objects. So, it's a good idea to prefer one name to another.

Maybe it will be a good idea to add config options for name that testing.* objects should have. At now you can disable tb_name check if necessary.

PS. git search has a lot of restrictions. I think, statistics of usage is ambiguous.

[prashantv]

Since changing the required name to t testing.TB would be a breaking change and could be disruptive, I think other options would be preferred. However, I think the default behaviour should match common usage, so my preferences are (in-order):

• Allow both t testing.TB and tb testing.TB by default. Though there could be multiple names for the same type, this also matches real-world usage, so I'm not sure how much confusion that could cause.
• Allow cusotmization of the name, though the default will not match the common usage, and requires additional work to pass on most Go code.

Regarding the git search restrictions, I agree the exact numbers are not likely to be accurate, but the ratio is still quite a useful signal, especially when other systems provide similar data,

• using grep.app, we see t testing.TB has ~4 times as many results as tb testing.TB
• using sourcegraph, we see t testing.TB has ~6 times as many results as tb testing.TB

It seems like t testing.TB is more commonly used, so ideally the linter would allow that by default.