Merge pull request #11454 from janisz/fix_extract_error

bug: return error on invalid function name in extract.TranslatableStrings

Author: sharifelgamal

pkg/minikube/extract/extract.go

@@ -92,7 +92,7 @@ func newExtractor(functionsToCheck []string) (*state, error) {
 		// Functions must be of the form "package.function"
 		t2 := strings.Split(t, ".")
 		if len(t2) < 2 {
-			return nil, errors.Wrap(nil, fmt.Sprintf("Invalid function string %s. Needs package name as well.", t))
+			return nil, errors.Errorf("invalid function string %s. Needs package name as well", t)
 		}
 		f := funcType{
 			pack: t2[0],

pkg/minikube/extract/extract_test.go

@@ -18,6 +18,7 @@ package extract
 
 import (
 	"encoding/json"
+	"errors"
 	"io/ioutil"
 	"os"
 	"path/filepath"
@@ -84,3 +85,12 @@ func TestExtract(t *testing.T) {
 	}
 
 }
+
+func TestExtractShouldReturnErrorOnFunctionWithoutPackage(t *testing.T) {
+	expected := errors.New("Initializing: invalid function string missing_package. Needs package name as well")
+	funcs := []string{"missing_package"}
+	err := TranslatableStrings([]string{}, funcs, "")
+	if err == nil || err.Error() != expected.Error() {
+		t.Fatalf("expected %v, got %v", expected, err)
+	}
+}