Skip to content

Scripts use go mod vendor but vendor directory isn't checked inΒ #147

@nojnhuh

Description

@nojnhuh

Using the scripts in the repo to build the driver from source runs go mod vendor which populates the local ./vendor directory. Since that dependency code is not checked in (and even ignored), switching to a branch that modifies go.mod makes it inconsistent with the local vendor directory which confuses the go command until go mod vendor is run again.

There are broadly two paths we could take:

  1. Stop using go mod vendor
  2. Check in the vendor directory

I'd generally prefer to stop using go mod vendor to align with the default behavior of the go command. I understand that vendoring dependencies makes the repo resilient to certain kinds of GitHub and GOPROXY failures or if a dependency disappears or its tags are mismanaged. I think our non-k8s.io dependencies are limited enough that maintaining a vendor directory isn't worth the hassle.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    πŸ”– Ready

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions