Skip to content

Commit 2b5cadd

Browse files
Karthik-K-Nk8s-infra-cherrypick-robot
authored andcommitted
Fix bug while setting status for deprecated fields
1 parent 620dfbc commit 2b5cadd

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

util/deprecated/v1beta1/patch/utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ func identifyConditionsFieldsPath(obj runtime.Object) ([]string, []string, error
187187
// We assume the type is implemented according to transition guidelines
188188
clusterv1ConditionsFields = []string{"status", "deprecated", "v1beta1", "conditions"}
189189
} else {
190-
if v1Beta1Field := deprecatedElem.FieldByName("V1Beta1"); deprecatedField != (reflect.Value{}) {
190+
if v1Beta1Field := deprecatedElem.FieldByName("V1Beta1"); v1Beta1Field != (reflect.Value{}) {
191191
if v1Beta1Field.Kind() != reflect.Pointer {
192192
return nil, nil, errors.New("obj.status.deprecated.v1beta1 must be a pointer")
193193
}

util/patch/utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ func identifyConditionsFieldsPath(obj runtime.Object) ([]string, []string, error
187187
// We assume the type is implemented according to transition guidelines
188188
clusterv1ConditionsFields = []string{"status", "deprecated", "v1beta1", "conditions"}
189189
} else {
190-
if v1Beta1Field := deprecatedElem.FieldByName("V1Beta1"); deprecatedField != (reflect.Value{}) {
190+
if v1Beta1Field := deprecatedElem.FieldByName("V1Beta1"); v1Beta1Field != (reflect.Value{}) {
191191
if v1Beta1Field.Kind() != reflect.Pointer {
192192
return nil, nil, errors.New("obj.status.deprecated.v1beta1 must be a pointer")
193193
}

0 commit comments

Comments
 (0)