fix modals and pdf sharing (#28806)

* need to  sub since this changes

* fix mobile pdf

Author: chrisnojima

shared/chat/conversation/messages/attachment/file.tsx

@@ -66,7 +66,7 @@ const FileContainer = React.memo(function FileContainer(p: OwnProps) {
   const navigateAppend = C.useRouterState(s => s.dispatch.navigateAppend)
   const onDownload = React.useCallback(() => {
     if (C.isMobile) {
-      messageAttachmentNativeShare(ordinal)
+      messageAttachmentNativeShare(ordinal, true)
     } else if (!downloadPath) {
       if (fileType === 'application/pdf') {
         navigateAppend({

shared/constants/chat2/convostate.tsx

@@ -250,7 +250,7 @@ export interface ConvoState extends ConvoStore {
     markThreadAsRead: (force?: boolean) => void
     markTeamAsRead: (teamID: T.Teams.TeamID) => void
     messageAttachmentNativeSave: (ordinal: T.Chat.Ordinal) => void
-    messageAttachmentNativeShare: (ordinal: T.Chat.Ordinal) => void
+    messageAttachmentNativeShare: (ordinal: T.Chat.Ordinal, fromDownload?: boolean) => void
     messageDelete: (ordinal: T.Chat.Ordinal) => void
     messageDeleteHistory: () => void
     messageReplyPrivately: (ordinal: T.Chat.Ordinal) => void
@@ -1851,7 +1851,7 @@ const createSlice: Z.ImmerStateCreator<ConvoState> = (set, get) => {
       }
       ignorePromise(f())
     },
-    messageAttachmentNativeShare: ordinal => {
+    messageAttachmentNativeShare: (ordinal, fromDownload = false) => {
       const message = get().messageMap.get(ordinal)
       if (message?.type !== 'attachment') {
         throw new Error('Invalid share message')
@@ -1864,7 +1864,8 @@ const createSlice: Z.ImmerStateCreator<ConvoState> = (set, get) => {
           return
         }
 
-        if (isIOS && message.fileName.endsWith('.pdf')) {
+        // kinda hacky, on download we need to download and showing
+        if (isIOS && message.fileName.endsWith('.pdf') && fromDownload) {
           navigateAppend({
             props: {
               conversationIDKey: get().id,

shared/router-v2/left-tab-navigator.desktop.tsx

@@ -1,10 +1,10 @@
 import * as React from 'react'
 import * as Kb from '@/common-adapters'
-import * as C from '@/constants'
 import TabBar from './tab-bar.desktop'
 import {useNavigationBuilder, TabRouter, createNavigatorFactory} from '@react-navigation/core'
 import type {TypedNavigator, NavigatorTypeBagBase, StaticConfig} from '@react-navigation/native'
 import type * as Tabs from '@/constants/tabs'
+import * as Router2 from '@/constants/router2'
 
 type BackBehavior = Parameters<typeof TabRouter>[0]['backBehavior']
 type Props = Parameters<typeof useNavigationBuilder>[1] & {backBehavior: BackBehavior}
@@ -50,7 +50,7 @@ const LeftTabNavigator = React.memo(function LeftTabNavigator({
     setRendered(next)
   }, [selectedRoute, rendered])
 
-  const hasModals = C.Router2.getModalStack().length > 0
+  const hasModals = Router2.useRouterState(() => Router2.getModalStack().length > 0)
 
   return (
     <NavigationContent>