From 6b129303a5a86d43cc4217f6d35ee896323b0073 Mon Sep 17 00:00:00 2001 From: Netopya Date: Fri, 6 Sep 2019 17:18:50 -0400 Subject: [PATCH] [kenwheeler/slick#3691] Fix extra cloned slides This for loop iterates over too many slides. In fact it iterates beyond the number of slides but jQuery fails silently once it exceeds the slides. The result is that too many slides get cloned and appended to the end of the track. This previously caused issues fixed with [kenwheeler/slick#3809]. This remaining fix is a minor performance improvement by trimming out the cloned slides that are never visible. --- slick/slick.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/slick/slick.js b/slick/slick.js index bb94a86d4..5e5eb34b2 100644 --- a/slick/slick.js +++ b/slick/slick.js @@ -2444,7 +2444,7 @@ .attr('data-slick-index', slideIndex - _.slideCount) .prependTo(_.$slideTrack).addClass('slick-cloned'); } - for (i = 0; i < infiniteCount + _.slideCount; i += 1) { + for (i = 0; i < infiniteCount; i += 1) { slideIndex = i; $(_.$slides[slideIndex]).clone(true).attr('id', '') .attr('data-slick-index', slideIndex + _.slideCount)