Skip to content

simulation params errors are ignored #1

@MarshallAsch

Description

@MarshallAsch

(Mostly a comment to my self for when I take over this codebase)

In the following code block where the cli parameter are parsed and an ok result is passed back:

std::tie(params, ok) = SimulationParameters::parse(argc, argv);

This ok value is never used and ignored. The simulation will still run using the potentially invalid parameters.

If the parameters have an issue and fail to be parsed correctly the experiment should terminate with an error code.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions