Fixed UUValidator.ScanBeginMarker to always return false until Payload

jstedfast · jstedfast · commit 5162c0bd0f95 · 2026-01-24T13:32:15.000-05:00
diff --git a/MimeKit/Encodings/UUValidator.cs b/MimeKit/Encodings/UUValidator.cs
@@ -153,15 +153,15 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)
 						if (inptr == inend) {
 							streamOffset += (int) (inptr - start);
 							nsaved = *(inptr - 1);
-							return true;
+							return false;
 						}
 
 						SkipByte (ref inptr);
 
 						streamOffset += (int) (inptr - start);
 
 						if (inptr == inend)
-							return true;
+							return false;
 					}
 
 					nsaved = ReadByte (ref inptr);
@@ -177,7 +177,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)
 
 					state = UUValidatorState.B;
 					if (inptr == inend)
-						return true;
+						return false;
 				}
 
 				if (state == UUValidatorState.B) {
@@ -189,7 +189,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)
 
 					state = UUValidatorState.Be;
 					if (inptr == inend)
-						return true;
+						return false;
 				}
 
 				if (state == UUValidatorState.Be) {
@@ -201,7 +201,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)
 
 					state = UUValidatorState.Beg;
 					if (inptr == inend)
-						return true;
+						return false;
 				}
 
 				if (state == UUValidatorState.Beg) {
@@ -213,7 +213,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)
 
 					state = UUValidatorState.Begi;
 					if (inptr == inend)
-						return true;
+						return false;
 				}
 
 				if (state == UUValidatorState.Begi) {
@@ -225,7 +225,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)
 
 					state = UUValidatorState.Begin;
 					if (inptr == inend)
-						return true;
+						return false;
 				}
 
 				if (state == UUValidatorState.Begin) {
@@ -239,7 +239,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)
 					nsaved = 0;
 
 					if (inptr == inend)
-						return true;
+						return false;
 				}
 
 				if (state == UUValidatorState.FileMode) {
@@ -257,7 +257,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)
 					}
 
 					if (inptr == inend)
-						return true;
+						return false;
 
 					if (nsaved < 3) {
 						// file mode is too short
@@ -276,7 +276,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)
 					nsaved = 0;
 
 					if (inptr == inend)
-						return true;
+						return false;
 				}
 
 				if (state == UUValidatorState.FileName) {
@@ -301,7 +301,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)
 				}
 			}
 
-			return true;
+			return false;
 		}
 
 #if NET6_0_OR_GREATER

Original file line number	Diff line number	Diff line change
`@@ -153,15 +153,15 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)`
`153`	`153`	`if (inptr == inend) {`
`154`	`154`	`streamOffset += (int) (inptr - start);`
`155`	`155`	`nsaved = *(inptr - 1);`
`156`		`- return true;`
	`156`	`+ return false;`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`SkipByte (ref inptr);`
`160`	`160`
`161`	`161`	`streamOffset += (int) (inptr - start);`
`162`	`162`
`163`	`163`	`if (inptr == inend)`
`164`		`- return true;`
	`164`	`+ return false;`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`nsaved = ReadByte (ref inptr);`
`@@ -177,7 +177,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)`
`177`	`177`
`178`	`178`	`state = UUValidatorState.B;`
`179`	`179`	`if (inptr == inend)`
`180`		`- return true;`
	`180`	`+ return false;`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`if (state == UUValidatorState.B) {`
`@@ -189,7 +189,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)`
`189`	`189`
`190`	`190`	`state = UUValidatorState.Be;`
`191`	`191`	`if (inptr == inend)`
`192`		`- return true;`
	`192`	`+ return false;`
`193`	`193`	`}`
`194`	`194`
`195`	`195`	`if (state == UUValidatorState.Be) {`
`@@ -201,7 +201,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)`
`201`	`201`
`202`	`202`	`state = UUValidatorState.Beg;`
`203`	`203`	`if (inptr == inend)`
`204`		`- return true;`
	`204`	`+ return false;`
`205`	`205`	`}`
`206`	`206`
`207`	`207`	`if (state == UUValidatorState.Beg) {`
`@@ -213,7 +213,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)`
`213`	`213`
`214`	`214`	`state = UUValidatorState.Begi;`
`215`	`215`	`if (inptr == inend)`
`216`		`- return true;`
	`216`	`+ return false;`
`217`	`217`	`}`
`218`	`218`
`219`	`219`	`if (state == UUValidatorState.Begi) {`
`@@ -225,7 +225,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)`
`225`	`225`
`226`	`226`	`state = UUValidatorState.Begin;`
`227`	`227`	`if (inptr == inend)`
`228`		`- return true;`
	`228`	`+ return false;`
`229`	`229`	`}`
`230`	`230`
`231`	`231`	`if (state == UUValidatorState.Begin) {`
`@@ -239,7 +239,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)`
`239`	`239`	`nsaved = 0;`
`240`	`240`
`241`	`241`	`if (inptr == inend)`
`242`		`- return true;`
	`242`	`+ return false;`
`243`	`243`	`}`
`244`	`244`
`245`	`245`	`if (state == UUValidatorState.FileMode) {`
`@@ -257,7 +257,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)`
`257`	`257`	`}`
`258`	`258`
`259`	`259`	`if (inptr == inend)`
`260`		`- return true;`
	`260`	`+ return false;`
`261`	`261`
`262`	`262`	`if (nsaved < 3) {`
`263`	`263`	`// file mode is too short`
`@@ -276,7 +276,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)`
`276`	`276`	`nsaved = 0;`
`277`	`277`
`278`	`278`	`if (inptr == inend)`
`279`		`- return true;`
	`279`	`+ return false;`
`280`	`280`	`}`
`281`	`281`
`282`	`282`	`if (state == UUValidatorState.FileName) {`
`@@ -301,7 +301,7 @@ unsafe bool ScanBeginMarker (ref byte* inptr, byte* inend)`
`301`	`301`	`}`
`302`	`302`	`}`
`303`	`303`
`304`		`- return true;`
	`304`	`+ return false;`
`305`	`305`	`}`
`306`	`306`
`307`	`307`	`#if NET6_0_OR_GREATER`