Skip to content

Unify code style with jsdom #286

@asamuzaK

Description

@asamuzaK

Per #278 (comment)


Thanks for following my requests here. I'm happy to discuss this in more detail in a friendly manner :).

Personally, I think linear flow for code is an anti-goal. It is more important for code reading that the code central to a file be at the top and that other code be at the bottom, in my opinion.

I do agree consistency is important. So I think defining it in ESLint one way or another is a good idea.

For cssstyle, since you are doing most of the work, I am happy to let you set the style guidelines. That is why I put the part about function style as "I suggest"; the part I felt strongly about was no dead code, but the style was just a suggestion. I am sorry if that was not clear.

If you want to unify with jsdom, I think that is a great idea. (jsdom uses func-style to enforce declarations.) Of course, the jsdom codebase is all using my personal style. But if you would prefer to set your own style for this project, that is fine too.

Originally posted by @domenic in #278 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions