Skip to content

Commit d913ecf

Browse files
author
sam
committed
fix(examples): use CERT_PATH environment variable in client_server examples
Updates Python client scripts to use CERT_PATH environment variable for certificate paths instead of hardcoded relative paths. This ensures tests work correctly regardless of working directory. Changes: - client.py: Use os.getenv('CERT_PATH') with Path-based fallback - async_client.py: Use os.getenv('CERT_PATH') with Path-based fallback - Makefile: Pass CERT_PATH to both client tests
1 parent d0bd2a6 commit d913ecf

3 files changed

Lines changed: 12 additions & 4 deletions

File tree

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -509,9 +509,9 @@ python-example-client-server:
509509
@echo "Starting server..."
510510
@cd examples/python/client_server && PYTHON=$(VENV_PYTHON) $(VENV_PYTHON) $(ROOT_DIR)/examples/python/client_server/server.py & echo $$! > /tmp/rpcnet_test_server.pid && sleep 10
511511
@echo "Running blocking client test..."
512-
@cd examples/python/client_server && timeout 60 $(VENV_PYTHON) $(ROOT_DIR)/examples/python/client_server/client.py || (kill $$(cat /tmp/rpcnet_test_server.pid) 2>/dev/null; rm -f /tmp/rpcnet_test_server.pid; exit 1)
512+
@cd examples/python/client_server && CERT_PATH=$(ROOT_DIR)/certs/test_cert.pem timeout 60 $(VENV_PYTHON) $(ROOT_DIR)/examples/python/client_server/client.py || (kill $$(cat /tmp/rpcnet_test_server.pid) 2>/dev/null; rm -f /tmp/rpcnet_test_server.pid; exit 1)
513513
@echo "Running async client test..."
514-
@cd examples/python/client_server && timeout 60 $(VENV_PYTHON) $(ROOT_DIR)/examples/python/client_server/async_client.py || (kill $$(cat /tmp/rpcnet_test_server.pid) 2>/dev/null; rm -f /tmp/rpcnet_test_server.pid; exit 1)
514+
@cd examples/python/client_server && CERT_PATH=$(ROOT_DIR)/certs/test_cert.pem timeout 60 $(VENV_PYTHON) $(ROOT_DIR)/examples/python/client_server/async_client.py || (kill $$(cat /tmp/rpcnet_test_server.pid) 2>/dev/null; rm -f /tmp/rpcnet_test_server.pid; exit 1)
515515
@kill $$(cat /tmp/rpcnet_test_server.pid) 2>/dev/null || true
516516
@rm -f /tmp/rpcnet_test_server.pid
517517
@echo "✅ Client/Server example passed"

examples/python/client_server/async_client.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import asyncio
33
import sys
44
import time
5+
import os
56
from pathlib import Path
67

78
sys.path.insert(0, str(Path(__file__).parent / "generated"))
@@ -14,9 +15,12 @@ async def main():
1415
print("🚀 RpcNet Async Client")
1516
print("=" * 70)
1617

18+
# Use environment variable or default relative path
19+
cert_path = os.getenv("CERT_PATH", str(Path(__file__).parent.parent.parent.parent / "certs" / "test_cert.pem"))
20+
1721
client = await BenchmarkServiceClient.connect(
1822
addr="127.0.0.1:50051",
19-
cert_path="../../../certs/test_cert.pem",
23+
cert_path=cert_path,
2024
server_name="localhost"
2125
)
2226
print("✅ Connected")

examples/python/client_server/client.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
#!/usr/bin/env python3
22
import sys
33
import time
4+
import os
45
from pathlib import Path
56

67
sys.path.insert(0, str(Path(__file__).parent / "generated"))
@@ -13,9 +14,12 @@ def main():
1314
print("🚀 RpcNet Client")
1415
print("=" * 70)
1516

17+
# Use environment variable or default relative path
18+
cert_path = os.getenv("CERT_PATH", str(Path(__file__).parent.parent.parent.parent / "certs" / "test_cert.pem"))
19+
1620
client = BenchmarkServiceBlockingClient.connect(
1721
addr="127.0.0.1:50051",
18-
cert_path="../../../certs/test_cert.pem",
22+
cert_path=cert_path,
1923
server_name="localhost",
2024
timeout_secs=10
2125
)

0 commit comments

Comments
 (0)