Skip to content

Commit 9067343

Browse files
committed
Build: Really test on Firefox ESR, new & old
The previous config declared Firefox ESR testing, but the tests were never run due to clashing names with main Firefox test runs. Apart from fixing that, backport jquery/jquery#5682 so that both Firefox ESR versions can be downloaded despite using different compression algorithms. Ref jquery/jquery#5682
1 parent e28ef35 commit 9067343

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

.github/workflows/browser-tests.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,14 @@ env:
1212
jobs:
1313
test:
1414
runs-on: ubuntu-latest
15-
name: ${{ matrix.BROWSER }} (${{ matrix.MIGRATE_VERSION }} Migrate)
15+
name: ${{ matrix.NAME || matrix.BROWSER }} (${{ matrix.MIGRATE_VERSION }} Migrate)
1616
strategy:
1717
fail-fast: false
1818
matrix:
1919
BROWSER: ["chrome", "firefox"]
2020
MIGRATE_VERSION: ["min"]
2121
include:
22-
- NAME: "Node"
23-
BROWSER: "chrome"
22+
- BROWSER: "chrome"
2423
MIGRATE_VERSION: "esmodules"
2524
- NAME: "Firefox ESR (new)"
2625
BROWSER: "firefox"
@@ -57,7 +56,13 @@ jobs:
5756

5857
- name: Install Firefox ESR
5958
run: |
60-
wget --no-verbose $FIREFOX_SOURCE_URL -O - | tar -jx -C ${HOME}
59+
# Support: Firefox <135 only
60+
# Older Firefox used to be compressed using bzip2, newer using xz. Try
61+
# to uncompress using xz, fall back to bzip2 if that fails.
62+
# Note: this will download the old Firefox ESR twice, but it will still work
63+
# when the current ESR version starts to use xz with no changes to the code.
64+
wget --no-verbose "$FIREFOX_SOURCE_URL" -O - | tar -Jx -C "$HOME" || \
65+
wget --no-verbose "$FIREFOX_SOURCE_URL" -O - | tar -jx -C "$HOME"
6166
echo "PATH=${HOME}/firefox:$PATH" >> "$GITHUB_ENV"
6267
echo "FIREFOX_BIN=${HOME}/firefox/firefox" >> "$GITHUB_ENV"
6368
if: contains(matrix.NAME, 'Firefox ESR')

0 commit comments

Comments
 (0)