Skip to content

Commit e080ab9

Browse files
authored
Remove pip upgrade from CI (#153)
* Remove pip upgrade from CI In certain environments, pip fails when it is invoked directly; it requires running it via the `python -m pip`. ``` 2024-07-01T15:36:28.7531716Z ##[group]Run pip install --upgrade pip 2024-07-01T15:36:28.7532786Z ␛[36;1mpip install --upgrade pip␛[0m 2024-07-01T15:36:28.7657862Z shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'" 2024-07-01T15:36:28.7658373Z env: 2024-07-01T15:36:28.7658824Z pythonLocation: C:\hostedtoolcache\windows\Python\3.8.10\x64 2024-07-01T15:36:28.7659493Z PKG_CONFIG_PATH: C:\hostedtoolcache\windows\Python\3.8.10\x64/lib/pkgconfig 2024-07-01T15:36:28.7660136Z Python_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.8.10\x64 2024-07-01T15:36:28.7660710Z Python2_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.8.10\x64 2024-07-01T15:36:28.7661290Z Python3_ROOT_DIR: C:\hostedtoolcache\windows\Python\3.8.10\x64 2024-07-01T15:36:28.7661929Z JAVA_HOME: C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.412-8\x64 2024-07-01T15:36:28.7662624Z JAVA_HOME_8_X64: C:\hostedtoolcache\windows\Java_Temurin-Hotspot_jdk\8.0.412-8\x64 2024-07-01T15:36:28.7663174Z ##[endgroup] 2024-07-01T15:36:38.7384905Z Requirement already satisfied: pip in c:\hostedtoolcache\windows\python\3.8.10\x64\lib\site-packages (24.1) 2024-07-01T15:36:39.0876540Z Collecting pip 2024-07-01T15:36:39.1091359Z Downloading pip-24.1.1-py3-none-any.whl.metadata (3.6 kB) 2024-07-01T15:36:39.1792167Z Downloading pip-24.1.1-py3-none-any.whl (1.8 MB) 2024-07-01T15:36:39.2204216Z ---------------------------------------- 1.8/1.8 MB 58.5 MB/s eta 0:00:00 2024-07-01T15:36:39.3613861Z ERROR: To modify pip, please run the following command: 2024-07-01T15:36:39.3615157Z c:\hostedtoolcache\windows\python\3.8.10\x64\python.exe -m pip install --upgrade pip 2024-07-01T15:36:39.4510941Z 2024-07-01T15:36:39.4512808Z [notice] A new release of pip is available: 24.1 -> 24.1.1 2024-07-01T15:36:39.4514062Z [notice] To update, run: python.exe -m pip install --upgrade pip 2024-07-01T15:36:39.9822011Z ##[error]Process completed with exit code 1. ``` While we could update the CI to plumb it through `python -m pip`, we can likely achieve better reproducibility and determinism by using the version of pip that is already installed. * Reintroduce setuptools
1 parent 50e375f commit e080ab9

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@ jobs:
7676
distribution: 'temurin'
7777
java-version: '8'
7878

79-
- run: pip install --upgrade pip
80-
- run: pip install --upgrade setuptools
79+
- run: pip install setuptools
8180
- run: ${{ matrix.info.cmd }}
8281

8382
- uses: actions/upload-artifact@v4

.github/workflows/check.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
distribution: 'temurin'
2626
java-version: ${{ matrix.java }}
2727

28-
- run: pip install --upgrade setuptools
28+
- run: pip install setuptools
2929

3030
- name: Run Test
3131
run: python setup.py test

0 commit comments

Comments
 (0)