support for legacySubset in sylvester, row and column

Author: dvd101x

src/expression/transform/column.transform.js

@@ -4,7 +4,7 @@ import { createColumn } from '../../function/matrix/column.js'
 import { isNumber } from '../../utils/is.js'
 
 const name = 'column'
-const dependencies = ['typed', 'Index', 'matrix', 'range']
+const dependencies = ['typed', 'Index', 'matrix', 'range', 'config']
 
 /**
  * Attach a transform function to matrix.column
@@ -13,8 +13,8 @@ const dependencies = ['typed', 'Index', 'matrix', 'range']
  * This transform changed the last `index` parameter of function column
  * from zero-based to one-based
  */
-export const createColumnTransform = /* #__PURE__ */ factory(name, dependencies, ({ typed, Index, matrix, range }) => {
-  const column = createColumn({ typed, Index, matrix, range })
+export const createColumnTransform = /* #__PURE__ */ factory(name, dependencies, ({ typed, Index, matrix, range, config }) => {
+  const column = createColumn({ typed, Index, matrix, range, config })
 
   // @see: comment of column itself
   return typed('column', {

src/expression/transform/row.transform.js

@@ -4,7 +4,7 @@ import { errorTransform } from './utils/errorTransform.js'
 import { isNumber } from '../../utils/is.js'
 
 const name = 'row'
-const dependencies = ['typed', 'Index', 'matrix', 'range']
+const dependencies = ['typed', 'Index', 'matrix', 'range', 'config']
 
 /**
  * Attach a transform function to matrix.column
@@ -13,8 +13,8 @@ const dependencies = ['typed', 'Index', 'matrix', 'range']
  * This transform changed the last `index` parameter of function column
  * from zero-based to one-based
  */
-export const createRowTransform = /* #__PURE__ */ factory(name, dependencies, ({ typed, Index, matrix, range }) => {
-  const row = createRow({ typed, Index, matrix, range })
+export const createRowTransform = /* #__PURE__ */ factory(name, dependencies, ({ typed, Index, matrix, range, config }) => {
+  const row = createRow({ typed, Index, matrix, range, config })
 
   // @see: comment of row itself
   return typed('row', {

src/function/algebra/sylvester.js

@@ -94,6 +94,10 @@ export const createSylvester = /* #__PURE__ */ factory(name, dependencies, (
     }
   })
   function _sylvester (A, B, C) {
+    // chek if legacySubset is enabled and disable it temporarily
+    const originalConfigForLegacySubset = config().legacySubset
+    if (originalConfigForLegacySubset) config({ legacySubset: false })
+
     const n = B.size()[0]
     const m = A.size()[0]
 
@@ -142,6 +146,8 @@ export const createSylvester = /* #__PURE__ */ factory(name, dependencies, (
     const Y = matrix(matrixFromColumns(...y))
     const X = multiply(U, multiply(Y, transpose(V)))
 
+    // restore original config for legacySubset
+    if (originalConfigForLegacySubset) config({ legacySubset: true })
     return X
   }
 })

src/function/matrix/column.js

@@ -4,9 +4,9 @@ import { clone } from '../../utils/object.js'
 import { validateIndex } from '../../utils/array.js'
 
 const name = 'column'
-const dependencies = ['typed', 'Index', 'matrix', 'range']
+const dependencies = ['typed', 'Index', 'matrix', 'range', 'config']
 
-export const createColumn = /* #__PURE__ */ factory(name, dependencies, ({ typed, Index, matrix, range }) => {
+export const createColumn = /* #__PURE__ */ factory(name, dependencies, ({ typed, Index, matrix, range, config }) => {
   /**
    * Return a column from a Matrix.
    *
@@ -19,7 +19,7 @@ export const createColumn = /* #__PURE__ */ factory(name, dependencies, ({ typed
    *     // get a column
    *     const d = [[1, 2], [3, 4]]
    *     math.column(d, 1) // returns [[2], [4]]
-   *
+   *np
    * See also:
    *
    *     row
@@ -48,11 +48,19 @@ export const createColumn = /* #__PURE__ */ factory(name, dependencies, ({ typed
       throw new Error('Only two dimensional matrix is supported')
     }
 
+    // chek if legacySubset is enabled and disable it temporarily
+    const originalConfigForLegacySubset = config().legacySubset
+    if (originalConfigForLegacySubset) config({ legacySubset: false })
+
     validateIndex(column, value.size()[1])
 
     const rowRange = range(0, value.size()[0])
     const index = new Index(rowRange, [column])
     const result = value.subset(index)
+    
+    // restore original config for legacySubset
+    if (originalConfigForLegacySubset) config({ legacySubset: true })
+
     return isMatrix(result)
       ? result
       : matrix([[result]])

src/function/matrix/row.js

@@ -4,9 +4,9 @@ import { clone } from '../../utils/object.js'
 import { validateIndex } from '../../utils/array.js'
 
 const name = 'row'
-const dependencies = ['typed', 'Index', 'matrix', 'range']
+const dependencies = ['typed', 'Index', 'matrix', 'range', 'config']
 
-export const createRow = /* #__PURE__ */ factory(name, dependencies, ({ typed, Index, matrix, range }) => {
+export const createRow = /* #__PURE__ */ factory(name, dependencies, ({ typed, Index, matrix, range, config }) => {
   /**
    * Return a row from a Matrix.
    *
@@ -47,12 +47,19 @@ export const createRow = /* #__PURE__ */ factory(name, dependencies, ({ typed, I
     if (value.size().length !== 2) {
       throw new Error('Only two dimensional matrix is supported')
     }
+    // chek if legacySubset is enabled and disable it temporarily
+    const originalConfigForLegacySubset = config().legacySubset
+    if (originalConfigForLegacySubset) config({ legacySubset: false })
 
     validateIndex(row, value.size()[0])
 
     const columnRange = range(0, value.size()[1])
     const index = new Index([row], columnRange)
     const result = value.subset(index)
+
+    // restore original config for legacySubset
+    if (originalConfigForLegacySubset) config({ legacySubset: true })
+
     return isMatrix(result)
       ? result
       : matrix([[result]])